2.8.1 can't serialize and deserialize date null (2.8.0 works fine)

[xanscale]

W/System.err: com.google.gson.JsonParseException: The date should be a string value
W/System.err:     at com.google.gson.DefaultDateTypeAdapter.read(DefaultDateTypeAdapter.java:96)
W/System.err:     at com.google.gson.DefaultDateTypeAdapter.read(DefaultDateTypeAdapter.java:40)
W/System.err:     at com.google.gson.internal.bind.ReflectiveTypeAdapterFactory$1.read(ReflectiveTypeAdapterFactory.java:129)
W/System.err:     at com.google.gson.internal.bind.ReflectiveTypeAdapterFactory$Adapter.read(ReflectiveTypeAdapterFactory.java:220)
W/System.err:     at com.google.gson.internal.bind.TypeAdapterRuntimeTypeWrapper.read(TypeAdapterRuntimeTypeWrapper.java:41)
W/System.err:     at com.google.gson.internal.bind.CollectionTypeAdapterFactory$Adapter.read(CollectionTypeAdapterFactory.java:82)
W/System.err:     at com.google.gson.internal.bind.CollectionTypeAdapterFactory$Adapter.read(CollectionTypeAdapterFactory.java:61)

gson/gson/src/main/java/com/google/gson/DefaultDateTypeAdapter.java

Line 95 in b8f616c

if (in.peek() != JsonToken.STRING) {

this will trows JsonParseException

    if (in.peek() != JsonToken.STRING) {
      throw new JsonParseException("The date should be a string value");
    }

this is my conf
new GsonBuilder().serializeNulls().setDateFormat("yyyy-MM-dd'T'HH:mm:ss.SSS").create()

[inder123]

Can you create a PR with a failing test? Thanks.

[tylerOrMe]

Having similar issue in serialization.

Gson gson = new GsonBuilder().setDateFormat("yyyy-MM-dd'T'HH:mm:ss.SSS'Z'").create()
gson.toJson(myObjectWhoContainsNullDates)

throws NullPointerException from Gson 2.8.1
2.8.0 works fine.

if you remove setDateFormat serialization works

Gson gson = new GsonBuilder().create()
gson.toJson(myObjectWhoContainsNullDates)

[SergeyTrukhachev]

Faced the same issue with 2.8.1.
2.8.0 works well.

[bmarty]

Hi,

This is my workaround for this bug, waiting for 2.8.2:

private Gson getGson() {
    // Trick to get the DefaultDateTypeAdatpter instance
    // Create a first instance a Gson
    Gson gson = new GsonBuilder()
            .setDateFormat(DATE_FORMAT_COMPLETE)
            .create();

    // Get the date adapter
    TypeAdapter<Date> dateTypeAdapter = gson.getAdapter(Date.class);

    // Ensure the DateTypeAdapter is null safe
    TypeAdapter<Date> safeDateTypeAdapter = dateTypeAdapter.nullSafe();

    // Build the definitive safe Gson instance
    return new GsonBuilder()
            .registerTypeAdapter(Date.class, safeDateTypeAdapter)
            .create();
}

Hope it will help

BR

[rafa-js]

Nice @bmarty .
I get the impression the last .setDateFormat(DATE_FORMAT_COMPLETE) is not needed. You actually defined within the safeDateTypeAdapter all the details to parse the date.

[bmarty]

@rafa0809 yes, indeed!

[nachodd]

Facing the same .
Edit: @bmarty solution worked for me. And also the 2.8.0 worked fine.

[mohamedmelsayed]

TypeAdapter safeDateTypeAdapter = dateTypeAdapter.nullSafe();

it worked for me @bmarty
thank you