New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify handling of non-object omitted fields #1169

Merged
merged 1 commit into from Oct 28, 2017

Conversation

Projects
None yet
3 participants
@elharo
Member

elharo commented Oct 11, 2017

fix ##1166

@inder123 While deserializing, a missing entry in JSON results in setting the corresponding field in the object to its default value: null for object types, zero for numeric types, and false for booleans.

Also added some missing periods and corrected one word.

Clarify handling of non-object omitted fields
While deserializing, a missing entry in JSON results in setting the corresponding field in the object to its default value: null for object types, zero for numeric types, and false for booleans.

@googlebot googlebot added the cla: yes label Oct 11, 2017

@elharo

This comment has been minimized.

Show comment
Hide comment
@elharo

elharo Oct 14, 2017

Member

Looks like there's a flaky test. Someone with commit rights may need to restart it.

Member

elharo commented Oct 14, 2017

Looks like there's a flaky test. Someone with commit rights may need to restart it.

@inder123

This comment has been minimized.

Show comment
Hide comment
@inder123

inder123 Oct 28, 2017

Collaborator

Thank you!

Collaborator

inder123 commented Oct 28, 2017

Thank you!

@inder123 inder123 merged commit 28344d8 into google:master Oct 28, 2017

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
cla/google All necessary CLAs are signed
codacy/pr Good work! A positive pull request.
Details

sebasjm pushed a commit to sebasjm/gson that referenced this pull request Mar 11, 2018

Clarify handling of non-object omitted fields (google#1169)
While deserializing, a missing entry in JSON results in setting the corresponding field in the object to its default value: null for object types, zero for numeric types, and false for booleans.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment