New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java 9 module #1179

Merged
merged 2 commits into from Dec 26, 2017

Conversation

Projects
None yet
4 participants
@michaelsavich
Contributor

michaelsavich commented Oct 26, 2017

I've added a module-info.java file. Right now it's disabled by default-- I'm no maven wizard, so I didn't want to mess with the pom more than absolutely necessary. To try compiling the GSON as a jigsaw module, delete <excludes>**/module-info.java</excludes> and set java.version to 1.9, then run mvn compile.

@michaelsavich

This comment has been minimized.

Show comment
Hide comment
@michaelsavich

michaelsavich Oct 26, 2017

Contributor

Hey, can someone check what's going on with Travis CI? It seems like everybody's builds are failing…

Contributor

michaelsavich commented Oct 26, 2017

Hey, can someone check what's going on with Travis CI? It seems like everybody's builds are failing…

@googlebot

This comment has been minimized.

Show comment
Hide comment
@googlebot

googlebot Oct 26, 2017

Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.
Collaborator

googlebot commented Oct 26, 2017

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@googlebot googlebot added the cla: no label Oct 26, 2017

@michaelsavich

This comment has been minimized.

Show comment
Hide comment
@michaelsavich

michaelsavich Oct 26, 2017

Contributor
Contributor

michaelsavich commented Oct 26, 2017

@googlebot

This comment has been minimized.

Show comment
Hide comment
@googlebot

googlebot Oct 26, 2017

Collaborator

CLAs look good, thanks!

Collaborator

googlebot commented Oct 26, 2017

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Oct 26, 2017

@Foorack

This comment has been minimized.

Show comment
Hide comment
@Foorack

Foorack Dec 23, 2017

Can Travish be re-run? It looks like the error is with the CI system (JAVA_HOME not set) rather than with this pull request.

Foorack commented Dec 23, 2017

Can Travish be re-run? It looks like the error is with the CI system (JAVA_HOME not set) rather than with this pull request.

@inder123

Thank you

@inder123 inder123 merged commit 7ddac52 into google:master Dec 26, 2017

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
cla/google All necessary CLAs are signed
codacy/pr Good work! A positive pull request.
Details

sebasjm pushed a commit to sebasjm/gson that referenced this pull request Mar 11, 2018

Java 9 module (google#1179)
* Add module-info.java

* Exclude module-info.java by default
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment