Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor CostructorConstructor to be stateless #1534

Closed
wants to merge 1 commit into from
Closed

Refactor CostructorConstructor to be stateless #1534

wants to merge 1 commit into from

Conversation

Degubi
Copy link
Contributor

@Degubi Degubi commented May 16, 2019

  • Remove ConstructorConstructor.java constructor, make all methods static
  • Remove CostructorConstructor field from gson, pass the instanceCreator map to adapters
  • Remove ReflectionAccessor fields, no need to store them in fields, avoids loading some classes when not used(Reflection classes)

@Degubi Degubi changed the title Refactor CostructorConstructor to be a stateless class Refactor CostructorConstructor to be stateless May 16, 2019
@inder123
Copy link
Collaborator

why is this preferred over existing implementation @Degubi ?

@Degubi
Copy link
Contributor Author

Degubi commented May 24, 2019 •
edited

why is this preferred over existing implementation @Degubi ?

  • Remove some unnecessary constructors and state.
  • Avoid loading some classes.
    Nothing special, just to remove some unnecessary code bloat.

@Degubi Degubi closed this Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Degubi @inder123 @googlebot