Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify BagOfPrimitives if statement #1539

Merged

Conversation

@WilliamCollishaw
Copy link
Contributor

commented Jun 2, 2019

Removes some redundant if statements

@googlebot googlebot added the cla: yes label Jun 2, 2019

@googlebot

This comment has been minimized.

Copy link
Collaborator

commented Jun 4, 2019

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no and removed cla: yes labels Jun 4, 2019

@inder123 inder123 merged commit aa236ec into google:master Jun 4, 2019

0 of 2 checks passed

cla/google CLAs are signed, but unable to verify author consent
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@WilliamCollishaw WilliamCollishaw deleted the WilliamCollishaw:simplify-BagOfPrimitives-if-statement branch Jun 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.