Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep `TypeAdapter`s from being stripped #1546

Merged
merged 1 commit into from Oct 3, 2019

Conversation

@hqzxzwb
Copy link
Contributor

hqzxzwb commented Jul 1, 2019

TypeAdapter implementations used in JsonAdapter annotation sometimes are never instantiated explicitly without reflection, causing R8 to strip their instance methods.

@googlebot

This comment has been minimized.

Copy link
Collaborator

googlebot commented Jul 1, 2019

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no label Jul 1, 2019
@hqzxzwb

This comment has been minimized.

Copy link
Contributor Author

hqzxzwb commented Jul 1, 2019

I signed it!

@googlebot

This comment has been minimized.

Copy link
Collaborator

googlebot commented Jul 1, 2019

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Jul 1, 2019
@hqzxzwb

This comment has been minimized.

Copy link
Contributor Author

hqzxzwb commented Jul 24, 2019

Do I need to do anything more for this getting reviewed?

@inder123 inder123 self-assigned this Oct 3, 2019
@inder123 inder123 merged commit d6e6a01 into google:master Oct 3, 2019
2 checks passed
2 checks passed
cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.