Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fallback behavior of UnsafeReflectionAllocator when AccessibleObject isn't so accessible #1712

Merged
merged 1 commit into from Aug 4, 2021

Conversation

rhernandez35
Copy link
Contributor

@rhernandez35 rhernandez35 commented May 27, 2020

I'm the lucky owner of a post-jigsaw Java platform that has restrictive security manager installed. Failing to catch the SecurityException thrown by a cross-classloader getDeclaredField call in UnsafeReflectionAllocator::getOverrideField prevents any Gson instances from being created.

I'm hoping the fallback behavior in this class will be enough for us to use Gson without having to loosen our security policy.

@googlebot
Copy link

@googlebot googlebot commented May 27, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@rhernandez35
Copy link
Contributor Author

@rhernandez35 rhernandez35 commented Jun 17, 2020

@googlebot I signed it!

@googlebot
Copy link

@googlebot googlebot commented Jun 17, 2020

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@eamonnmcmanus
Copy link
Member

@eamonnmcmanus eamonnmcmanus commented Aug 4, 2021

This looks reasonable. Thanks for the carefully-constructed test!

@eamonnmcmanus eamonnmcmanus merged commit 63e747f into google:master Aug 4, 2021
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants