Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RuntimeTypeAdapterFactory depending on internal Streams class #1959


Copy link

Fixes #1931

Additionally makes gson-extras a Maven module of gson-parent and cleans up its POM.
Deploying for gson-extras is disabled, hopefully this is respected by the Maven Release Plugin.

@Marcono1234 Marcono1234 force-pushed the marcono1234/RuntimeTypeAdapterFactory-no-internal-dependencies branch from bb6ce33 to 097e196 Compare September 11, 2021 04:22
Copy link

@eamonnmcmanus eamonnmcmanus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I guess we'll see whether the deploy configuration works the next time we release.

@eamonnmcmanus eamonnmcmanus merged commit 26a1928 into google:master Sep 18, 2021
@Marcono1234 Marcono1234 deleted the marcono1234/RuntimeTypeAdapterFactory-no-internal-dependencies branch September 18, 2021 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

RuntimeTypeAdapterFactory depends on internal API (JPMS, Java 9+)
2 participants