Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RuntimeTypeAdapterFactory depending on internal Streams class #1959

Conversation

@Marcono1234
Copy link
Contributor

@Marcono1234 Marcono1234 commented Sep 11, 2021

Fixes #1931

Additionally makes gson-extras a Maven module of gson-parent and cleans up its POM.
Deploying for gson-extras is disabled, hopefully this is respected by the Maven Release Plugin.

@Marcono1234 Marcono1234 force-pushed the marcono1234/RuntimeTypeAdapterFactory-no-internal-dependencies branch from bb6ce33 to 097e196 Sep 11, 2021
Copy link
Member

@eamonnmcmanus eamonnmcmanus left a comment

Thanks! I guess we'll see whether the deploy configuration works the next time we release.

@eamonnmcmanus eamonnmcmanus merged commit 26a1928 into google:master Sep 18, 2021
2 checks passed
@Marcono1234 Marcono1234 deleted the marcono1234/RuntimeTypeAdapterFactory-no-internal-dependencies branch Sep 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants