Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FieldNamingPolicy.upperCaseFirstLetter uppercasing non-letter #2004

Conversation

Marcono1234
Copy link
Collaborator

@Marcono1234 Marcono1234 commented Oct 29, 2021

Fixes #1965

Note: separateCamelCase could be refactored to avoid appending each char one by one (example implementation), however I am not sure if that is really a performance improvement, so I have not changed that.

@google-cla google-cla bot added the cla: yes label Oct 29, 2021
@Marcono1234 Marcono1234 reopened this Oct 29, 2021
@eamonnmcmanus
Copy link
Member

eamonnmcmanus commented Nov 1, 2021

This is great, thanks! Love the new tests.

@eamonnmcmanus eamonnmcmanus merged commit b3188c1 into google:master Nov 1, 2021
4 of 5 checks passed
@Marcono1234 Marcono1234 deleted the marcono1234/FieldNamingPolicy-upperCaseFirstLetter-fix branch Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FieldNamingPolicy.upperCaseFirstLetter uppercases trailing non-letters
2 participants