Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JsonReader.hasNext() returning true at end of document #2061

Conversation

Marcono1234
Copy link
Collaborator

@Marcono1234 Marcono1234 commented Jan 23, 2022

Fixes #1049

This is also consistent with the documentation for JsonReader.hasNext():

Returns true if the current array or object has another element.

@Marcono1234 Marcono1234 force-pushed the marcono1234/JsonReader-hasNext-end-of-document branch from 60db6d8 to e601973 Compare Jan 23, 2022
@eamonnmcmanus
Copy link
Member

eamonnmcmanus commented Jan 27, 2022

I tried this against all of Google's internal tests and everything worked.

@eamonnmcmanus eamonnmcmanus merged commit 710a76c into google:master Jan 27, 2022
4 checks passed
@Marcono1234 Marcono1234 deleted the marcono1234/JsonReader-hasNext-end-of-document branch Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JsonReader.hasNext() returns true at END_DOCUMENT
2 participants