Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codegen removal #2099

Merged
merged 5 commits into from Apr 4, 2022
Merged

codegen removal #2099

merged 5 commits into from Apr 4, 2022

Conversation

kentrachmat
Copy link
Contributor

@kentrachmat kentrachmat commented Apr 3, 2022

Thank you for your reply, in this PR i have deleted the whole codegen file

@google-cla
Copy link

google-cla bot commented Apr 3, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

Copy link
Member

@eamonnmcmanus eamonnmcmanus left a comment

Thanks! We do need a signed CLA before we can merge, though.

pom.xml Outdated
@@ -13,15 +13,14 @@
<artifactId>gson-parent</artifactId>
<version>2.9.1-SNAPSHOT</version>
<packaging>pom</packaging>

Copy link
Member

@eamonnmcmanus eamonnmcmanus Apr 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem necessary?

Copy link
Contributor Author

@kentrachmat kentrachmat Apr 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes sorry, i was trying to solve the CLA problem, this is actually my first ever PR and i thought by changing my email in the next commit would solve this problem

@kentrachmat kentrachmat closed this Apr 3, 2022
@kentrachmat kentrachmat reopened this Apr 3, 2022
@kentrachmat kentrachmat closed this Apr 3, 2022
@kentrachmat kentrachmat reopened this Apr 3, 2022
@eamonnmcmanus eamonnmcmanus merged commit b2b1424 into google:master Apr 4, 2022
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants