Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit support for floats in JsonTreeWriter. #2132

merged 1 commit into from Jun 21, 2022


Copy link

@Capstan Capstan commented Jun 10, 2022

Follow-up to comments on #2130, which introduced a new override which was not overridden by JsonTreeWriter. Also tweaks the doccomments for the float, double, and Number variants of JsonWriter.value.

Supplement to the fix for #1127.

Follow-up to comments on google#2130, which introduced a new override which was not overridden by `JsonTreeWriter`. Also tweaks the doccomments for `float`, `double` and `Number` variants of `JsonWriter.value`.

Supplement to the fix for google#1127.
Copy link
Contributor Author

Capstan commented Jun 11, 2022

/cc @eamonnmcmanus

Copy link

I'll give @Marcono1234 a chance to comment this time before merging. :-)
It seems like a mistake for JsonTreeWriter to extend JsonWriter, but probably not one we can fix. I'm somewhat tempted to add a test that will fail if you add a value overload to JsonWriter and don't override it in JsonTreeWriter, but it's kind of like locking the stable door after the horse has bolted.

Copy link

@Marcono1234 Marcono1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll give @Marcono1234 a chance to comment this time before merging. :-)

Looks good to me. It is also great that this adjusts the tests to cover the newly added method!

Copy link
Contributor Author

Capstan commented Jun 21, 2022

Does this need further review?

@eamonnmcmanus eamonnmcmanus merged commit d2aee65 into google:master Jun 21, 2022
sgammon added a commit to elide-dev/elide that referenced this pull request Jan 15, 2023

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
| []( |
`2.9.0` -> `2.10.1` |
| []( |
`2.9.0` -> `2.10.1` |


### ⚠ Dependency Lookup Warnings ⚠

Warnings were logged while processing this repo. Please check the
Dependency Dashboard for more information.


### Release Notes



- Support for serializing and deserializing Java records, on Java ≥ 16.
- Add `JsonArray.asList` and `JsonObject.asMap` view methods
- Fix `TypeAdapterRuntimeTypeWrapper` not detecting reflective
`TreeTypeAdapter` and `FutureTypeAdapter`
- Improve `JsonReader.skipValue()`
- Perform numeric conversion for primitive numeric type adapters
- Add `Gson.fromJson(..., TypeToken)` overloads
- Fix changes to `GsonBuilder` affecting existing `Gson` instances
- Make `JsonElement` conversion methods more consistent and fix javadoc
- Throw `UnsupportedOperationException` when `JsonWriter.jsonValue` is
not supported
- Disallow `JsonObject` `Entry.setValue(null)`
- Fix `TypeAdapter.toJson` throwing AssertionError for custom
- Convert null to JsonNull for `JsonArray.set`
- Fixed nullSafe usage.
- Validate `TypeToken.getParameterized` arguments
- Fix [#&#8203;1702](
Gson.toJson creates CharSequence which does not implement toString
- Prefer existing adapter for concurrent `Gson.getAdapter` calls
- Improve `ArrayTypeAdapter` for `Object[]`
- Improve `AppendableWriter` performance


- Make `Object` and `JsonElement` deserialization iterative rather than

- Added parsing support for enum that has overridden toString() method
- Removed support for building Gson with Gradle
- Removed obsolete `codegen` hierarchy
- Add support for reflection access filter
- Improve `TypeToken` creation validation
- Add explicit support for `float` in `JsonWriter`
- Fail when parsing invalid local date

Also many small improvements to javadoc.



### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these
updates again.


- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box


This PR has been generated by [Mend
Renovate]( View
repository job log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants