Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit support for floats in JsonTreeWriter. #2132

Merged
merged 1 commit into from Jun 21, 2022

Conversation

Capstan
Copy link
Contributor

@Capstan Capstan commented Jun 10, 2022

Follow-up to comments on #2130, which introduced a new override which was not overridden by JsonTreeWriter. Also tweaks the doccomments for the float, double, and Number variants of JsonWriter.value.

Supplement to the fix for #1127.

Follow-up to comments on google#2130, which introduced a new override which was not overridden by `JsonTreeWriter`. Also tweaks the doccomments for `float`, `double` and `Number` variants of `JsonWriter.value`.

Supplement to the fix for google#1127.
@Capstan
Copy link
Contributor Author

Capstan commented Jun 11, 2022

/cc @eamonnmcmanus

@eamonnmcmanus
Copy link
Member

eamonnmcmanus commented Jun 13, 2022

I'll give @Marcono1234 a chance to comment this time before merging. :-)
It seems like a mistake for JsonTreeWriter to extend JsonWriter, but probably not one we can fix. I'm somewhat tempted to add a test that will fail if you add a value overload to JsonWriter and don't override it in JsonTreeWriter, but it's kind of like locking the stable door after the horse has bolted.

Copy link
Collaborator

@Marcono1234 Marcono1234 left a comment

I'll give @Marcono1234 a chance to comment this time before merging. :-)

Looks good to me. It is also great that this adjusts the tests to cover the newly added method!

@Capstan
Copy link
Contributor Author

Capstan commented Jun 21, 2022

Does this need further review?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants