Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail when parsing invalid local date #2134



Copy link

Fixes #2133

To me this looks like an oversight because by when time information is provided, setLenient(false) is called a few lines below.

Copy link

@eamonnmcmanus mind to take a look at this one? I'm the author of #2133 and LGTM.

Copy link

This looks OK to me, but I'm going to run it past all of Google's tests to be sure.

@eamonnmcmanus eamonnmcmanus merged commit 57225c6 into google:master Jun 16, 2022
@Marcono1234 Marcono1234 deleted the marcono1234/invalid-date-exception branch June 16, 2022 21:39
sgammon added a commit to elide-dev/elide that referenced this pull request Jan 15, 2023

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
| []( |
`2.9.0` -> `2.10.1` |
| []( |
`2.9.0` -> `2.10.1` |


### ⚠ Dependency Lookup Warnings ⚠

Warnings were logged while processing this repo. Please check the
Dependency Dashboard for more information.


### Release Notes



- Support for serializing and deserializing Java records, on Java ≥ 16.
- Add `JsonArray.asList` and `JsonObject.asMap` view methods
- Fix `TypeAdapterRuntimeTypeWrapper` not detecting reflective
`TreeTypeAdapter` and `FutureTypeAdapter`
- Improve `JsonReader.skipValue()`
- Perform numeric conversion for primitive numeric type adapters
- Add `Gson.fromJson(..., TypeToken)` overloads
- Fix changes to `GsonBuilder` affecting existing `Gson` instances
- Make `JsonElement` conversion methods more consistent and fix javadoc
- Throw `UnsupportedOperationException` when `JsonWriter.jsonValue` is
not supported
- Disallow `JsonObject` `Entry.setValue(null)`
- Fix `TypeAdapter.toJson` throwing AssertionError for custom
- Convert null to JsonNull for `JsonArray.set`
- Fixed nullSafe usage.
- Validate `TypeToken.getParameterized` arguments
- Fix [#&#8203;1702](
Gson.toJson creates CharSequence which does not implement toString
- Prefer existing adapter for concurrent `Gson.getAdapter` calls
- Improve `ArrayTypeAdapter` for `Object[]`
- Improve `AppendableWriter` performance


- Make `Object` and `JsonElement` deserialization iterative rather than

- Added parsing support for enum that has overridden toString() method
- Removed support for building Gson with Gradle
- Removed obsolete `codegen` hierarchy
- Add support for reflection access filter
- Improve `TypeToken` creation validation
- Add explicit support for `float` in `JsonWriter`
- Fail when parsing invalid local date

Also many small improvements to javadoc.



### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these
updates again.


- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box


This PR has been generated by [Mend
Renovate]( View
repository job log

@Marcono1234 Marcono1234 mentioned this pull request Nov 12, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

ISO8061Utils.parse() accepts non-existent dates
3 participants