Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail when parsing invalid local date #2134

Merged

Conversation

Marcono1234
Copy link
Collaborator

@Marcono1234 Marcono1234 commented Jun 12, 2022

Fixes #2133

To me this looks like an oversight because by when time information is provided, setLenient(false) is called a few lines below.

@JPedroAmorim
Copy link

JPedroAmorim commented Jun 13, 2022

@eamonnmcmanus mind to take a look at this one? I'm the author of #2133 and LGTM.

@eamonnmcmanus
Copy link
Member

eamonnmcmanus commented Jun 14, 2022

This looks OK to me, but I'm going to run it past all of Google's tests to be sure.

@eamonnmcmanus eamonnmcmanus merged commit 57225c6 into google:master Jun 16, 2022
5 checks passed
@Marcono1234 Marcono1234 deleted the marcono1234/invalid-date-exception branch Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ISO8061Utils.parse() accepts non-existent dates
3 participants