Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from TSLint to Typescript ESLint #302

Closed
leeren opened this issue Mar 31, 2019 · 12 comments
Closed

Migrate from TSLint to Typescript ESLint #302

leeren opened this issue Mar 31, 2019 · 12 comments

Comments

@leeren
Copy link

@leeren leeren commented Mar 31, 2019

TSLint will eventually be deprecated in favor of TypeScript ESLint. It thus makes sense to convert from using tslint.json to a customized .eslintrc.* file and switch to using eslint.

@leeren leeren changed the title Migrate from tslint Migrate from TSLint to Typescript ESLint Mar 31, 2019
@vitkarpov

This comment has been minimized.

Copy link
Contributor

@vitkarpov vitkarpov commented Mar 31, 2019

@ofrobots makes sense 🤷‍♂️ Would you like a PR for that? I'd do that.

@ofrobots

This comment has been minimized.

Copy link
Collaborator

@ofrobots ofrobots commented Apr 1, 2019

While it makes sense to switch to eslint, but my feeling was that the eslint+typescript tooling/ecosystem was not going to be mature enough in time for the 1.0.0 release of gts (due out in a couple of weeks).

I think targeting this migration to a 2.0.0 sometime later this year makes more sense?

LMK if my impression is incorrect and if majority of the TypeScript ecosystem has already moved over to using eslint.

@vitkarpov

This comment has been minimized.

Copy link
Contributor

@vitkarpov vitkarpov commented Apr 2, 2019

TypeScript ecosystem has already moved over to using eslint

I don't think so, Palantir guys announced it only in February, a couple of months ago. Let's postpone to 2.0.0, I agree.

@lindner

This comment has been minimized.

Copy link

@lindner lindner commented May 30, 2019

I've been converting a project that uses gts rules to eslint if anyone wants some inspiration.

https://github.com/PolymerLabs/arcs/blob/master/config/eslintrc.json is the beginning. Also interested in working with anyone that wants to help push this forward.

@david-szabo97

This comment has been minimized.

Copy link

@david-szabo97 david-szabo97 commented Nov 18, 2019

Any update on this?

@JustinBeckwith

This comment has been minimized.

Copy link
Member

@JustinBeckwith JustinBeckwith commented Nov 18, 2019

Nothing yet :)

@haotangio

This comment has been minimized.

Copy link

@haotangio haotangio commented Dec 3, 2019

Hi, do we have any plan to do this yet?

@JustinBeckwith

This comment has been minimized.

Copy link
Member

@JustinBeckwith JustinBeckwith commented Dec 3, 2019

It's the plan, just haven't had time. There's a start in #400, but no timeline for it to be done yet.

@StephenHaney

This comment has been minimized.

Copy link

@StephenHaney StephenHaney commented Dec 17, 2019

Just chipping in some perspective: we're considering moving back to TSLint until the typescript-eslint repo matures.

Since migrating to ESLint, we've had A LOT of problems with extremely bad performance and poor TypeScript support with the vscode-eslint extension; it often crashes, gives odd errors, or hangs at 99% CPU (although this appears to be recently remedied).

Since moving to ESLint for TS, we're spending way too much time talking about debugging our linter.

I'm not saying don't do it – there are lots of talented people working hard on typescript-eslint; I have no doubt it will soon become the clear choice.

I'd suggest that you consider waiting until TSLint is actually deprecated if you're happy with how things work now. I'm not sure the VSCode extension support is there yet for ESLint... and make sure to test the change well and weigh the trade-offs of leaving a more mature setup.

@irlcatgirl

This comment has been minimized.

Copy link

@irlcatgirl irlcatgirl commented Dec 22, 2019

What changes are still needed to make this happen?

@JustinBeckwith

This comment has been minimized.

Copy link
Member

@JustinBeckwith JustinBeckwith commented Dec 22, 2019

Mostly need to discuss the changes in #400, and add a lot of tests.

@JustinBeckwith

This comment has been minimized.

Copy link
Member

@JustinBeckwith JustinBeckwith commented Jan 13, 2020

This is complete, and will be in the 2.x release :)

@namoscato namoscato mentioned this issue Jan 18, 2020
1 of 2 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
9 participants
You can’t perform that action at this time.