feat!: use eslint instead of tslint #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JustinBeckwith
commented
Dec 3, 2019
JustinBeckwith
force-pushed
the
eslint
branch
from
f01dabe
to
fac5b66
Compare
bcoe
approved these changes
Dec 30, 2019
There was a problem hiding this comment.
assuming that this is mostly a noop seems reasonable to consolidate on eslint:
- I'd love for us to check how the performance is on https://github.com/googleapis/google-api-nodejs-client, since this is the library that was bumping into memory issues linting.
- I'm curious as to why its own linting is failing.
JustinBeckwith
force-pushed
the
eslint
branch
from
0c421a8
to
884f7b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: Switch from tslint to eslint. This will impact all lint rules, and tslint specific configuration.