New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove @Beta from Files #3285
Comments
Can I work on this issue? |
collect - most Collectors (aside from BloomFilter and ImmutableRange*, as those whole classes are @beta (though I did remove the redundant @beta annotation from the Collector-returning methods for clarity)) - Maps: asConverter, immutableEnumMap - MultimapBuilder - Streams: stream(Iterable), concat io - ByteStreams: copy, toByteArray - CharStreams: copy, toString - Files: as(Char|Byte)(Source|Sink) util.concurrent - Futures: addCallback, getDone, getUnchecked, immediateCancelledFuture, immediateFailedFuture, immediateFuture - ListeningScheduledExecutorService - Uninterruptibles other - HtmlEscapers - Splitter.splitToList - Ticker Fixes #3287 Fixes #3251 (aside from ImmutableRange*, but those whole classes are @beta, anyway) Addresses the main concerns of #3285 but doesn't cover the broader request Fixes #3340 Partially addresses #3239 RELNOTES=Removed `@Beta` from a number of frequently used APIs. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=232681253
collect - most Collectors (aside from BloomFilter and ImmutableRange*, as those whole classes are @beta (though I did remove the redundant @beta annotation from the Collector-returning methods for clarity)) - Maps: asConverter, immutableEnumMap - MultimapBuilder - Streams: stream(Iterable), concat io - ByteStreams: copy, toByteArray - CharStreams: copy, toString - Files: as(Char|Byte)(Source|Sink) util.concurrent - Futures: addCallback, getDone, getUnchecked, immediateCancelledFuture, immediateFailedFuture, immediateFuture - ListeningScheduledExecutorService - Uninterruptibles other - HtmlEscapers - Splitter.splitToList - Ticker Fixes #3287 Fixes #3251 (aside from ImmutableRange*, but those whole classes are @beta, anyway) Addresses the main concerns of #3285 but doesn't cover the broader request Fixes #3340 Partially addresses #3239 RELNOTES=Removed `@Beta` from a number of frequently used APIs. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=232681253
collect - most Collectors (aside from BloomFilter and ImmutableRange*, as those whole classes are @beta (though I did remove the redundant @beta annotation from the Collector-returning methods for clarity)) - Maps: asConverter, immutableEnumMap - MultimapBuilder - Streams: stream(Iterable), concat io - ByteStreams: copy, toByteArray - CharStreams: copy, toString - Files: as(Char|Byte)(Source|Sink) util.concurrent - Futures: addCallback, getDone, getUnchecked, immediateCancelledFuture, immediateFailedFuture, immediateFuture - ListeningScheduledExecutorService - Uninterruptibles other - HtmlEscapers - Splitter.splitToList - Ticker Fixes #3287 Fixes #3251 (aside from ImmutableRange*, but those whole classes are @beta, anyway) Addresses the main concerns of #3285 but doesn't cover the broader request Fixes #3340 Partially addresses #3239 RELNOTES=Removed `@Beta` from a number of frequently used APIs. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=232681253
Since its been 2 years, Can someone please tell, why beta annotation cannot be removed on the mentioned place. ? It seems like a valid ask. |
We should absolutely review the use of As documented here and here, APIs annotated with |
@netdpb - Cool. Thanks for the reply. So... uh... |
That being said, the method the OP asked about ( |
Fixes #3285. RELNOTES=`io`: Remove `@Beta` from APIs in `Files`. PiperOrigin-RevId: 416632407
Fixes #3285. RELNOTES=`io`: Remove `@Beta` from APIs in `Files`. PiperOrigin-RevId: 416632407
Fixes #3285. RELNOTES=`io`: Remove `@Beta` from APIs in `Files`. PiperOrigin-RevId: 416632407
Fixes #3285. RELNOTES=`io`: Remove `@Beta` from APIs in `Files`. PiperOrigin-RevId: 416632407
Fixes #3285. RELNOTES=`io`: Remove `@Beta` from APIs in `Files`. PiperOrigin-RevId: 420062384
The
Files
class has been around since 1.0, so it would be nice to remove it from beta.(FYI, our main need at the moment is the
asByteSource
method [related to #3284]).The text was updated successfully, but these errors were encountered: