Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate buggy murmur3_32 and introduce murmur3_32_fixed. #5657

Closed
wants to merge 1 commit into from

Conversation

copybara-service[bot]
Copy link
Contributor

@copybara-service copybara-service bot commented Jul 26, 2021

Deprecate buggy murmur3_32 and introduce murmur3_32_fixed.

The bug was found by @findepi who also contributed the fix and the new tests via #5649.

Fixes #5648.

RELNOTES=hash: Deprecated buggy murmur3_32, and introduced murmur3_32_fixed.

@google-cla google-cla bot added the cla: yes label Jul 26, 2021
@copybara-service copybara-service bot force-pushed the test_386953108 branch 4 times, most recently from 385f664 to f0164f3 Compare August 2, 2021 01:21
@copybara-service copybara-service bot changed the title Fix a bug in hashing strings with non-BMP chars using Murmur3_32. Deprecate buggy murmur3_32 and introduce murmur3_32_fixed. Sep 7, 2021
The bug was found by @findepi who also contributed the fix and the new tests via #5649.

Fixes #5648.

RELNOTES=`hash`: Deprecated buggy `murmur3_32`, and introduced `murmur3_32_fixed`.
PiperOrigin-RevId: 386953108
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect hash result from murmur3_32 with String input containing surrogate pairs
1 participant