-
Notifications
You must be signed in to change notification settings - Fork 11k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Faster simplifyPath #752
Comments
Original comment posted by cpovirk@google.com on 2011-10-13 at 05:50 PM (No comment entered for this change.) Status: |
Original comment posted by kevinb@google.com on 2011-11-15 at 10:16 PM This is appreciated, but given how many problems we've had to deal with with this method, we're hesitant to do anything that makes the code even a little less understandable right now. In time we might gain more confidence that we finally have enough tests.... Labels: |
Original comment posted by thomas.andreas.jung on 2011-11-17 at 06:39 AM It's okay to close the issue. More issues in limbo won't help. (Rant:
|
Original comment posted by wasserman.louis on 2011-11-29 at 04:16 PM Thomas, I'm going to take a whack at making your implementation more readable without sacrificing speed. |
Original comment posted by fry@google.com on 2011-12-10 at 04:21 PM (No comment entered for this change.) Labels: |
Original comment posted by fry@google.com on 2012-02-16 at 07:17 PM (No comment entered for this change.) Status: |
Original comment posted by kevinb@google.com on 2012-06-22 at 06:16 PM (No comment entered for this change.) Status: |
Original issue created by thomas.andreas.jung on 2011-10-11 at 11:02 AM
I've reimplemented the Files.simplifyPath method. It works on two char
arrays. Scanning and and copying characters from the input char array
to the output char array. According to my microbenchmark it's at least
4 times faster than the current implementation. The readability of the
current implementation is much better than my implementation which is
quite low-level.
The text was updated successfully, but these errors were encountered: