Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify testCheckArgument_simpleMessage_failure to clean code #2248

Closed
wants to merge 2 commits into from

Conversation

intonormal
Copy link

verifySimpleMessage(expected) change to assertThat(expected).hasMessage("A message"),

so that the compared target("A message") can be saw straightway

@googlebot
Copy link
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@intonormal
Copy link
Author

I signed it!
this is my first contribute in open source
exciting and hope to be accepted

@googlebot
Copy link
Collaborator

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Dec 9, 2015
@cpovirk
Copy link
Member

cpovirk commented Jan 30, 2017

Sorry that we sat on this (and so many pull requests) for so long.

If "A message" appeared inline in the setup for the test, I would agree that there's a clear benefit to including it inline in the assertion. But it's already defined elsewhere, so this test already fails to be readable on its own :( You could probably fine a way to move all the information inline if you want, but I'd encourage you to look for something more substantial. Maybe #2394 if you're still interested.

@cpovirk cpovirk closed this Jan 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants