diff --git a/core/src/com/google/inject/internal/ProvidedByInternalFactory.java b/core/src/com/google/inject/internal/ProvidedByInternalFactory.java index 84fe3d2f84..0a0191db7c 100644 --- a/core/src/com/google/inject/internal/ProvidedByInternalFactory.java +++ b/core/src/com/google/inject/internal/ProvidedByInternalFactory.java @@ -58,8 +58,7 @@ public void initialize(InjectorImpl injector, Errors errors) throws ErrorsExcept providerBinding = injector.getBindingOrThrow(providerKey, errors, JitLimitation.NEW_OR_EXISTING_JIT); } - - @SuppressWarnings("unchecked")// + public T get(Errors errors, InternalContext context, Dependency dependency, boolean linked) throws ErrorsException { checkState(providerBinding != null, "not initialized"); @@ -67,7 +66,7 @@ public T get(Errors errors, InternalContext context, Dependency dependency, bool context.pushState(providerKey, providerBinding.getSource()); try { errors = errors.withSource(providerKey); - Provider provider = providerBinding.getInternalFactory().get( + Provider provider = providerBinding.getInternalFactory().get( errors, context, dependency, true); return circularGet(provider, errors, context, dependency, linked, provisionCallback); } finally { diff --git a/core/src/com/google/inject/spi/DefaultBindingTargetVisitor.java b/core/src/com/google/inject/spi/DefaultBindingTargetVisitor.java index e5cfd4d529..3deb9dd948 100644 --- a/core/src/com/google/inject/spi/DefaultBindingTargetVisitor.java +++ b/core/src/com/google/inject/spi/DefaultBindingTargetVisitor.java @@ -69,9 +69,9 @@ public V visit(ConvertedConstantBinding convertedConstantBinding) { return visitOther(convertedConstantBinding); } - // javac says it's an error to cast ProviderBinding to Binding @SuppressWarnings("unchecked") public V visit(ProviderBinding providerBinding) { - return visitOther((Binding) providerBinding); + // TODO(cushon): remove raw (Binding) cast when we don't care about javac 6 anymore + return visitOther((Binding) (Binding) providerBinding); } }