Permalink
Commits on Sep 18, 2018
Commits on Sep 17, 2018
  1. Fix the JDK11 opensource build for Guice. This was failing by chance …

    sameb authored and ronshapiro committed Sep 17, 2018
    …in the testlib tests because some of the tests were trying to create a JIT binding for "Integer", which caused Guice to try to parse Integer.class for line numbers. This failed because the JDK was 11, which compiles with "nest members", but our ASM (ASM6) doesn't support "nest members" yet.
    
    The only sane fix I can think of here is to just blanket ignore unsupported things when parsing line numbers, because even if your code is compiled for an earlier target (all of Guice's code+tests are compiled to target JDK 1.7), the JDK itself might be higher, and code may trigger Guice to try to do ASM operations against the JDK.
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=213313384
  2. Bump asm to 6.2.1, cglib to 3.2.8. The cglib bump should fix the JDK1…

    sameb authored and ronshapiro committed Sep 12, 2018
    …1 test failure, and the asm bump should provide better JDK11 compatibility in general.
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=212635520
  3. Correct example to use "plugins" consistently, rather than "urls". Po…

    dimo414 authored and ronshapiro committed Jul 24, 2018
    …inted out by @RiotR1cket on GitHub - c285193#commitcomment-29818566.
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=205895753
  4. Migrated from Subject.failWithRawMessage to Subject.failWithoutActual

    jlavallee authored and ronshapiro committed Jul 23, 2018
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=205720194
  5. Run tests on JDK 10 and 11 now that ASM has been updated to 6.2

    ronshapiro committed Jul 13, 2018
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=204491138
Commits on Jul 13, 2018
  1. Update guice opensource asm dep to 6.2.

    sameb authored and ronshapiro committed Jul 3, 2018
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=203129518
Commits on Jul 2, 2018
  1. Update to Guava 25.1-android.

    cpovirk authored and cgdecker committed Jun 30, 2018
    It's required by Truth 0.41, which we switched to in CL 200574789.
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=202732649
  2. Update to Truth 0.41, and expect a single failure-message format inst…

    cpovirk authored and cgdecker committed Jun 14, 2018
    …ead of the current multiple possibilities.
    
    Also, update the bundled-for-Ant JUnit from JUnit 3-something to JUnit 4.11. This matches the dependency used by the Maven build. It's necessary to avoid the problem "java.lang.ClassNotFoundException: org.junit.ComparisonFailure." Truth was already using that type as of 0.36[*], so I suspect that we were just getting away with the JUnit 3 dependency because of the vagaries of class loading. Presumably, if a test had ever actually failed in a way that should have produced a ComparisonFailure, the current build setup would have produces the same error.
    
    [*] https://github.com/google/truth/blob/release_0_36/core/src/main/java/com/google/common/truth/Platform.java#L24
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=200574789
Commits on May 25, 2018
  1. Ignore IllegalStateExceptions when loading classes for retrieving lin…

    sameb authored and ronshapiro committed May 23, 2018
    …e numbers.
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=197761929
Commits on May 16, 2018
  1. Make BoundFieldInfo public

    hapa authored and ronshapiro committed May 16, 2018
    And discover the bound fields when constructing the module, but deferring the errors to configure() time.
    
    This enables using BoundFieldModule with custom scoping in GuiceBerry/Acai using TestScopeListener/TestingService to reflectively reset the instance before tests.
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=196814191
Commits on May 15, 2018
  1. Adds a "null check and return false" code block in equals() method ov…

    sumitbhagwani authored and ronshapiro committed May 15, 2018
    …erridden by classes which would’ve otherwise thrown an NPE.
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=196668352
Commits on May 1, 2018
  1. Clarify behavior of setBinding().

    gonzojive authored and ronshapiro committed Apr 30, 2018
    Previous comment is ambiguous. It's unclear if OptionalBinder installs bindings or not:
    <p>If setDefault or setBinding are linked to Providers, the Provider may return {@code null}. If it does, the Optional bindings will be absent.
    
    In fact, bindings are installed (Optional<T> -> Optional.empty()).
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=194848832
Commits on Apr 24, 2018
  1. Add support for extensions into the proto SPI & convert them.

    sameb authored and ronshapiro committed Apr 24, 2018
    This converts the BindingProto to use oneofs instead of a type enum in order to let it grow more easily for extensions.
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=194102075
Commits on Apr 11, 2018
  1. Migrate off failWithRawMessageAndCause, which is being deprecated.

    cpovirk authored and ronshapiro committed Apr 10, 2018
    I'm sorry that the replacement is so ugly. Our reason for not supporting this directly is partially that it's needed by only ~1% of subjects. But mostly, we've over time taken the position that Truth is intended for only the "assert" phases of the "arrange, act, assert" testing process. Exceptions, on the other hand, usually come from the earlier phases.
    
    Unfortunately, I still owe everyone a long explanation of *why* we have come to this position. If it's bugging you now, let me know, and I can make it happen.
    
    (And yes, in this particular case, we're basically arguing that Your Subject Is Wrong. Sorry: I'm not trying to get you to delete it or recant or anything; I'm just trying to explain where we're coming from.)
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=192278109
Commits on Apr 9, 2018
  1. Fix Javadoc styling issues in SingletonScope.java.

    sweiss-google authored and ronshapiro committed Apr 6, 2018
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=191824861
Commits on Apr 3, 2018
  1. Update tests for upcoming changes to Truth's failure message format.

    cpovirk authored and ronshapiro committed Mar 28, 2018
    We now accept (sigh) 3 versions:
    - The version generated by the latest open-source release of Truth.
    - The version generated by the current internal version of Truth.
    - The version that will be generated once I submit CL 185043225.
    
    I continue to promise to reduce this back to expecting a single version once I release a version of Truth that contains CL 185043225.
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=190771332
Commits on Mar 27, 2018
  1. Updates javadoc to make the use of binding annotations on @Bind more …

    alanou authored and ronshapiro committed Mar 26, 2018
    …clear.
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=190471018
Commits on Mar 20, 2018
  1. Update tests for when withMessage() messages are displayed on separat…

    cpovirk authored and ronshapiro committed Mar 19, 2018
    …e lines from the main failure message.
    
    Before:
    some messsage: the main message
    
    After:
    some message
    the main message
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=189625749
Commits on Feb 28, 2018
  1. bump api diffs old api version & add 4.2 xml for comparison.

    sameb authored and ronshapiro committed Feb 28, 2018
    also update README
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=187365389
  2. bump snapshot version.

    sameb committed Feb 28, 2018
  3. add empty sources javadoc, per mccull's advice in #1161 (comment)

    sameb authored and ronshapiro committed Feb 28, 2018
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=187334858
  4. Add a README to multibindings/src per mccull@'s advice

    sameb authored and ronshapiro committed Feb 28, 2018
    Closes #1161
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=187327733
Commits on Feb 26, 2018
  1. Typo: "Lastest" -> "Latest"

    ronshapiro committed Feb 23, 2018
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=186768366
Commits on Feb 9, 2018
  1. Add missing @SInCE tags.

    netdpb authored and ronshapiro committed Feb 9, 2018
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=185159771
Commits on Feb 6, 2018
  1. Fix typo in pom.xml.

    yaziza authored and ronshapiro committed Feb 2, 2018
    Closes #986
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=184310513
Commits on Feb 2, 2018
  1. Add Automatic-Module-Names to Guice and all of the extensions

    ronshapiro committed Feb 2, 2018
    #1085
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=184283324
Commits on Jan 31, 2018
  1. Add oraclejdk9 to the Travis build matrix.

    netdpb authored and ronshapiro committed Jan 30, 2018
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=183882187
Commits on Jan 29, 2018
  1. Make BytecodeGen work with Java 9.

    jhmanson authored and ronshapiro committed Jan 26, 2018
    The name of the sun.reflect package has changed to jdk.internal.reflect
    in Java 9.  This was stopping the open-source testGuiceWorksInOSGiContainer test
    from passing.
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=183320310
  2. Update to cglib 3.2.6.

    jhmanson authored and ronshapiro committed Jan 26, 2018
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=183320182
Commits on Jan 25, 2018
  1. Use Guava 23.6-android instead of 19.0. The -android flavor preserves…

    netdpb authored and ronshapiro committed Jan 23, 2018
    … JDK7 compatibility.
    
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=183005740
  2. Bump version of maven-bundle-plugin; otherwise we're getting odd errors.

    netdpb authored and ronshapiro committed Jan 23, 2018
    -------------
    Created by MOE: https://github.com/google/moe
    MOE_MIGRATED_REVID=183004662