Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Semantic versioning of com.google.inject.multibindings package is violated because of API break in Guice 4.0. #1099

Open
nyssen opened this issue May 4, 2017 · 0 comments
Open

Semantic versioning of com.google.inject.multibindings package is violated because of API break in Guice 4.0. #1099

nyssen opened this issue May 4, 2017 · 0 comments

Comments

@nyssen
Copy link

nyssen commented May 4, 2017

In the 4.0 release the MultiBindingsTargetVisitor interface has been extended with an additional 'visit(OptionalBinderBinding<? extends T> optional binding)' method. This is an API break, as all implementers of the 3.0 version are now no longer compatible. The com.google.inject.multibindings package however still indicates compatibility by exporting version 1.4 instead of 2.0.
nyssen added a commit to eclipse/gef that referenced this issue May 4, 2017
@nyssen
[514764] Restrict Guice Multibindings to compatible version.
99b4572 
- As Guice Multibindings is not semantically versioned correctly (see
google/guice#1099), adjusted the version range
to [1.3.0, 1.4.0) to prevent compile problems.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nyssen