Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pseudoterminal job control #154

Closed
amscanne opened this issue Mar 25, 2019 · 2 comments
Closed

Pseudoterminal job control #154

amscanne opened this issue Mar 25, 2019 · 2 comments
Assignees
Labels
exported priority: p2 type: cleanup type: enhancement

Comments

@amscanne
Copy link
Collaborator

@amscanne amscanne commented Mar 25, 2019

gVisor PTYs must implement job control and related features. These include sessions, foreground/background processes, and signal handling.

@amscanne amscanne added type: cleanup type: enhancement exported priority: p2 labels Mar 25, 2019
@nhooyr
Copy link

@nhooyr nhooyr commented Apr 3, 2019

Is this issue related?

docker run --runtime=runsc -it --rm python python -c 'import pty; pty.spawn("/bin/sh")'

shows

/bin/sh: 0: can't access tty; job control turned off

And

docker run --runtime=runsc -it --rm python python -c 'import pty; pty.spawn("/bin/bash")'
bash: cannot set terminal process group (-1): Inappropriate ioctl for device
bash: no job control in this shell

@kevinGC
Copy link
Contributor

@kevinGC kevinGC commented Jun 9, 2021

At this point there is basic job control support implemented by #585 and #803. Closing this in favor of bugs like #422 that track specific features.

#6148 has been created to track the specific TODO still referring to this bug.

@kevinGC kevinGC closed this as completed Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exported priority: p2 type: cleanup type: enhancement
Projects
None yet
Development

No branches or pull requests

3 participants