From 006ac3a82e2597d9ef22f124191a9ee2b7ea8051 Mon Sep 17 00:00:00 2001 From: Nayana Bidari Date: Mon, 6 May 2024 15:31:42 -0700 Subject: [PATCH] Cleanup PiperOrigin-RevId: 631205039 --- test/syscalls/linux/proc_net.cc | 16 ---------------- 1 file changed, 16 deletions(-) diff --git a/test/syscalls/linux/proc_net.cc b/test/syscalls/linux/proc_net.cc index 8e64f832e3..4674573e55 100644 --- a/test/syscalls/linux/proc_net.cc +++ b/test/syscalls/linux/proc_net.cc @@ -224,9 +224,6 @@ PosixErrorOr GetSNMPMetricFromProc(const std::string snmp, TEST(ProcNetSnmp, TcpReset) { SKIP_IF(IsRunningWithHostinet()); - // TODO(gvisor.dev/issue/866): epsocket metrics are not savable. - DisableSave ds; - uint64_t oldAttemptFails; uint64_t oldActiveOpens; uint64_t oldOutRsts; @@ -281,9 +278,6 @@ TEST(ProcNetSnmp, TcpEstab) { // statistics have noise. SKIP_IF(GetMibsAllocationSysctl() == 0); - // TODO(gvisor.dev/issue/866): epsocket metrics are not savable. - DisableSave ds; - uint64_t oldEstabResets; uint64_t oldActiveOpens; uint64_t oldPassiveOpens; @@ -377,9 +371,6 @@ TEST(ProcNetSnmp, TcpEstab) { TEST(ProcNetSnmp, UdpNoPorts) { SKIP_IF(IsRunningWithHostinet()); - // TODO(gvisor.dev/issue/866): epsocket metrics are not savable. - DisableSave ds; - uint64_t oldOutDatagrams; uint64_t oldNoPorts; auto snmp = ASSERT_NO_ERRNO_AND_VALUE(GetContents("/proc/net/snmp")); @@ -420,9 +411,6 @@ TEST(ProcNetSnmp, UdpNoPorts) { TEST(ProcNetSnmp, UdpIn) { SKIP_IF(IsRunningWithHostinet()); - // TODO(gvisor.dev/issue/866): epsocket metrics are not savable. - const DisableSave ds; - uint64_t oldOutDatagrams; uint64_t oldInDatagrams; auto snmp = ASSERT_NO_ERRNO_AND_VALUE(GetContents("/proc/net/snmp")); @@ -550,10 +538,6 @@ TEST(ProcSysNetIpv4Recovery, Exists) { } TEST(ProcSysNetIpv4Recovery, CanReadAndWrite) { - // TODO(b/162988252): Enable save/restore for this test after the bug is - // fixed. - DisableSave ds; - SKIP_IF(!ASSERT_NO_ERRNO_AND_VALUE(HaveCapability((CAP_NET_ADMIN))) || IsRunningWithHostinet());