Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable runsc/boot support on arm64. #1176

Merged
merged 1 commit into from Nov 25, 2019
Merged

Conversation

@xiaobo55x
Copy link
Contributor

xiaobo55x commented Nov 12, 2019

Signed-off-by: Haibo Xu haibo.xu@arm.com
Change-Id: I00beb9cc492e44c762ebaa3750201c63c1f7c2f3

@googlebot googlebot added the cla: yes label Nov 12, 2019
@xiaobo55x

This comment has been minimized.

Copy link
Contributor Author

xiaobo55x commented Nov 12, 2019

Ref #63.

@xiaobo55x

This comment has been minimized.

Copy link
Contributor Author

xiaobo55x commented Nov 12, 2019

Hi @fvoznika, @prattmic,

Please help review this patch!

Thanks,
Haibo

@fvoznika fvoznika self-requested a review Nov 13, 2019
runsc/boot/loader_amd64.go Outdated Show resolved Hide resolved
runsc/boot/loader_arm64.go Outdated Show resolved Hide resolved
runsc/boot/filter/config.go Show resolved Hide resolved
This patch also include a minor change to replace syscall.Dup2
with syscall.Dup3 which was missed in a previous commit(ref a25a976).

Signed-off-by: Haibo Xu <haibo.xu@arm.com>
Change-Id: I00beb9cc492e44c762ebaa3750201c63c1f7c2f3
@xiaobo55x xiaobo55x force-pushed the xiaobo55x:runsc_boot branch from 88ee8d7 to 05871a1 Nov 13, 2019
@xiaobo55x xiaobo55x requested a review from fvoznika Nov 13, 2019
@avagin avagin added the kokoro:run label Nov 13, 2019
@gvisor-bot gvisor-bot removed the kokoro:run label Nov 13, 2019
Copy link
Member

fvoznika left a comment

Change looks good. Thanks!!

@xiaobo55x

This comment has been minimized.

Copy link
Contributor Author

xiaobo55x commented Nov 14, 2019

@fvoznika, thanks!

@xiaobo55x

This comment has been minimized.

Copy link
Contributor Author

xiaobo55x commented Nov 18, 2019

Hi @fvoznika,

It seems that this pull and #1177 were blocked by the feedback/copybara check failure, could you help have a look? BTW, I saw this kind of error several times before, and all of which were handled manfully by the reviewer. Is there any special attention we need to take when posting new patch to avoid this kind of check failure?

Thanks,
Haibo

gvisor-bot added a commit that referenced this pull request Nov 18, 2019
Signed-off-by: Haibo Xu <haibo.xu@arm.com>
Change-Id: I00beb9cc492e44c762ebaa3750201c63c1f7c2f3
FUTURE_COPYBARA_INTEGRATE_REVIEW=#1176 from xiaobo55x:runsc_boot 05871a1
PiperOrigin-RevId: 281104937
@fvoznika

This comment has been minimized.

Copy link
Member

fvoznika commented Nov 18, 2019

@xiaobo55x

This comment has been minimized.

Copy link
Contributor Author

xiaobo55x commented Nov 18, 2019

@fvoznika, thanks for the reply!

gvisor-bot added a commit that referenced this pull request Nov 22, 2019
Signed-off-by: Haibo Xu <haibo.xu@arm.com>
Change-Id: I00beb9cc492e44c762ebaa3750201c63c1f7c2f3
FUTURE_COPYBARA_INTEGRATE_REVIEW=#1176 from xiaobo55x:runsc_boot 05871a1
PiperOrigin-RevId: 281104937
gvisor-bot added a commit that referenced this pull request Nov 23, 2019
Signed-off-by: Haibo Xu <haibo.xu@arm.com>
Change-Id: I00beb9cc492e44c762ebaa3750201c63c1f7c2f3
FUTURE_COPYBARA_INTEGRATE_REVIEW=#1176 from xiaobo55x:runsc_boot 05871a1
PiperOrigin-RevId: 281104937
gvisor-bot added a commit that referenced this pull request Nov 25, 2019
Signed-off-by: Haibo Xu <haibo.xu@arm.com>
Change-Id: I00beb9cc492e44c762ebaa3750201c63c1f7c2f3
FUTURE_COPYBARA_INTEGRATE_REVIEW=#1176 from xiaobo55x:runsc_boot 05871a1
PiperOrigin-RevId: 281104937
gvisor-bot added a commit that referenced this pull request Nov 25, 2019
PiperOrigin-RevId: 282382564
@gvisor-bot gvisor-bot merged commit 05871a1 into google:master Nov 25, 2019
14 of 16 checks passed
14 of 16 checks passed
cla/google CLAs are signed, but unable to verify author consent
feedback/copybara Google internal checks FAILED for runs with create time 2019-11-14T22:25:57.893529081Z.
Details
KVM syscall tests Kokoro build finished
Details
build tests Kokoro build finished
Details
do tests Kokoro build finished
Details
docker tests Kokoro build finished
Details
go tests Kokoro build finished
Details
hostnet tests Kokoro build finished
Details
import/copybara Change imported to the internal review system
Details
kvm tests Kokoro build finished
Details
make tests Kokoro build finished
Details
overlay tests Kokoro build finished
Details
root tests Kokoro build finished
Details
simple tests Kokoro build finished
Details
sw-gso tests Kokoro build finished
Details
syscall tests Kokoro build finished
Details
@xiaobo55x xiaobo55x deleted the xiaobo55x:runsc_boot branch Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.