Fix stringification code for headerType (under pkg/tcpip/stack).
#12064
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was changed [when a new headertype (virtionetheader) was added](google@c06c9de#diff-18df233b2766aad71cf642c99506a0f1b3001e1cff462e57d0deb7c4839301c8, but the `_headerType_index` array wasn't updated correctly. I've fixed this by re-running stringer: ``` cd pkg/tcpip/stack go run golang.org/x/tools/cmd/stringer -type headerType . ```
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
ayushr2
reviewed
Aug 20, 2025
Collaborator
|
Could you also sign the CLA |
copybara-service bot
pushed a commit
that referenced
this pull request
Aug 20, 2025
This was changed [when a new headertype (virtionetheader) was added](c06c9de#diff-18df233b2766aad71cf642c99506a0f1b3001e1cff462e57d0deb7c4839301c8), but the `_headerType_index` array wasn't updated correctly. I've fixed this by re-running stringer: ``` cd pkg/tcpip/stack go run golang.org/x/tools/cmd/stringer -type headerType . ``` --- I found this when I was debugging a crash during memory-snapshot restoration. The error message says: `panic: consume must not be called twice: type ernetworkHeader`: https://github.com/google/gvisor/blob/c07c524742a7033ff4e8e8d7de9cf48929e1e484/pkg/tcpip/stack/packet_buffer.go#L347 FUTURE_COPYBARA_INTEGRATE_REVIEW=#12064 from abhagwat:apoorva/fix-stringification-for-headertype 88a33a9 PiperOrigin-RevId: 797469761
copybara-service bot
pushed a commit
that referenced
this pull request
Aug 20, 2025
This was changed [when a new headertype (virtionetheader) was added](c06c9de#diff-18df233b2766aad71cf642c99506a0f1b3001e1cff462e57d0deb7c4839301c8), but the `_headerType_index` array wasn't updated correctly. I've fixed this by re-running stringer: ``` cd pkg/tcpip/stack go run golang.org/x/tools/cmd/stringer -type headerType . ``` --- I found this when I was debugging a crash during memory-snapshot restoration. The error message says: `panic: consume must not be called twice: type ernetworkHeader`: https://github.com/google/gvisor/blob/c07c524742a7033ff4e8e8d7de9cf48929e1e484/pkg/tcpip/stack/packet_buffer.go#L347 FUTURE_COPYBARA_INTEGRATE_REVIEW=#12064 from abhagwat:apoorva/fix-stringification-for-headertype 88a33a9 PiperOrigin-RevId: 797469761
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was changed when a new headertype (virtionetheader) was added, but the
_headerType_indexarray wasn't updated correctly.I've fixed this by re-running stringer:
I found this when I was debugging a crash during memory-snapshot restoration. The error message says:
panic: consume must not be called twice: type ernetworkHeader:gvisor/pkg/tcpip/stack/packet_buffer.go
Line 347 in c07c524