New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build fails #23
Comments
Hi, thanks for reporting. We require GCC 4.8 for "alignas". Is it an option for you to compile with a more recent GCC or clang? |
Hi @jan-wassenberg, thanks for the reply. Here's my diff:
Unfortunately, compiling with gcc 4.9.1 leads with a whole set of other errors (though not with highwayhash), and the next-closest version I have is 4.7.2. I'm using a compute cluster so the gcc versions available to me are limited.
Here's the block of code. Could it be a syntax issue?
|
Hi, good news, it will compile with just a minor change; GCC wants the type first and attribute second. |
@jan-wassenberg still getting a similar error. Sorry for the silly fixes:
|
hehe, I see what happened. The Markdown syntax ate the underscores; it should read |
@jan-wassenberg Thank you so much! That worked! |
I've run into this issue (while compiling tensorflow) as well. @jan-wassenberg: if the change you suggested makes the code compatible with more gcc versions, why not to make it permanent? |
Hi @mnicky, it's a tradeoff - one disadvantage of |
@mnicky, if you are in a scientific computing Red Hat / CentOS environment, you might have more recent versions of gcc available. Try |
I have gcc 4.7.2 which is included in Debian Wheezy that runs on our cluster. In this case I'm able to modify the source file to get rid of the compilation error. I was just curious why the workaround/fix didn't get it into the master. I think there are still quite a few people running older versions of gcc without possibility of upgrading. And as highwayhash is needed to build tensorflow, I'd assume there are people affected by this. |
Ah, thanks for mentioning your GCC version. That's still fairly recent; it is unfortunate that alignas didn't make it in until 4.8. We will soon add a HH_ALIGNAS macro that resolves to alignas or falls back to attribute. |
The fix is in - please reopen if there's still an issue :) |
I am using GCC5.3.0, and getting a similar error: My set up is: |
Can you include more output to show the actual compile error and in which file/header it occurs? |
Sorry for the late reply. I started from scratch (including removing ~/.cache/bazel...), and it seems TF now compiles fine. Should I delete my previous message? |
Glad to hear it! No worries, we can leave this issue unchanged/closed. |
Hi guys/girls, I am having the same problem with gcc 4.7.4 |
@diegocrzt, you need to edit the file |
@rasmi, thank you for you quick answer and sorry for not understanding at first time, I was lost on the first markdown issues
|
@diegocrzt no problem. That is an unrelated issue. According to this thread, your version of gcc is too old. If you are using a scientific computing environment, try typing |
Thank you @rasmi, is clear for me now. I will see what can I do with my environment |
My build fails when compiling through Bazel (while building TensorFlow).
Adding the
-fpermissive
does allow it to continue with warnings, at which point I get this error:The text was updated successfully, but these errors were encountered: