Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
Clean up TODO in RapidTypeAnalyser since b/112859205 is fixed.
The inheriting types set of a member that has been polymorphically referenced can never be empty.

PiperOrigin-RevId: 230386393
  • Loading branch information
jDramaix authored and Copybara-Service committed Jan 22, 2019
1 parent 346935e commit fbc7767
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions tools/java/com/google/j2cl/tools/rta/RapidTypeAnalyser.java
Expand Up @@ -83,11 +83,10 @@ private void markMemberLive(Member member) {
}

private void unfoldPolymorphicReference(Member member) {
// Set of types inheriting this member
// Set of types inheriting this member (includes the enclosing type of the member).
Set<Type> inheritingTypes = typeHierarchyGraph.getTypesInheriting(member);
// TODO(b/112859205): Some static references ($clinit or static fields or unknown members) are
// flagged as dynamic references. Remove inheritingTypes.isEmpty() when it solved.
if (inheritingTypes.isEmpty() || containsLiveTypes(inheritingTypes)) {

if (containsLiveTypes(inheritingTypes)) {
markMemberLive(member);
} else {
// none of the possible types for this member is live. Register this member,
Expand Down

0 comments on commit fbc7767

Please sign in to comment.