diff --git a/.github/workflows/wheel_win_x64.yml b/.github/workflows/wheel_win_x64.yml index 93ad1351ec14..ac10378c63ce 100644 --- a/.github/workflows/wheel_win_x64.yml +++ b/.github/workflows/wheel_win_x64.yml @@ -38,7 +38,7 @@ jobs: run: | python -m pip install -r build/test-requirements.txt "C:\\msys64\\;C:\\msys64\\usr\\bin\\;" >> $env:GITHUB_PATH - python.exe build\build.py + python.exe build\build.py --bazel_options=--color=yes - uses: actions/upload-artifact@v3 with: diff --git a/.github/workflows/windows_ci.yml b/.github/workflows/windows_ci.yml index 24df00cb19fc..2da9ec2948d6 100644 --- a/.github/workflows/windows_ci.yml +++ b/.github/workflows/windows_ci.yml @@ -47,7 +47,7 @@ jobs: cd jax python -m pip install -r build/test-requirements.txt "C:\\msys64\\;C:\\msys64\\usr\\bin\\;" >> $env:GITHUB_PATH - python.exe build\build.py ('--bazel_options=--override_repository=xla=${{ github.workspace }}\xla' -replace '\\','\\') + python.exe build\build.py ('--bazel_options=--override_repository=xla=${{ github.workspace }}\xla' -replace '\\','\\') --bazel_options=--color=yes - uses: actions/upload-artifact@v3 with: diff --git a/tests/xla_bridge_test.py b/tests/xla_bridge_test.py index 439ec20e8fd8..f50f953f7751 100644 --- a/tests/xla_bridge_test.py +++ b/tests/xla_bridge_test.py @@ -13,6 +13,7 @@ # limitations under the License. import os +import platform import time import warnings @@ -92,7 +93,10 @@ def _mock_tpu_client(): def test_register_plugin(self): with self.assertLogs(level="WARNING") as log_output: - os.environ['PJRT_NAMES_AND_LIBRARY_PATHS'] = "name1:path1,name2:path2,name3" + if platform.system() == "windows": + os.environ['PJRT_NAMES_AND_LIBRARY_PATHS'] = "name1;path1,name2;path2,name3" + else: + os.environ['PJRT_NAMES_AND_LIBRARY_PATHS'] = "name1:path1,name2:path2,name3" xb.register_pjrt_plugin_factories_from_env() client_factory, priotiy = xb._backend_factories["name1"] with mock.patch.object(xc, "make_c_api_client", autospec=True) as mock_make: @@ -104,7 +108,7 @@ def test_register_plugin(self): self.assertRegex( log_output[1][0], r"invalid value name3 in env var PJRT_NAMES_AND_LIBRARY_PATHS" - r" name1:path1,name2:path2,name3", + r" name1.path1,name2.path2,name3", ) self.assertIn("name1", xb._backend_factories) self.assertIn("name2", xb._backend_factories)