Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in_parts and out_parts optional arguments jax.xla_computation. #3771

Merged
merged 1 commit into from Jul 15, 2020

Conversation

skye
Copy link
Collaborator

@skye skye commented Jul 15, 2020

This allows partitioned computations in xla_computation, like those produced by sharded_jit.

This allows partitioned computations in `xla_computation`, like those produced by `sharded_jit`.
Copy link
Contributor

@jekbradbury jekbradbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable! Maybe we could avoid the argument proliferation here in the future by having (a successor to) xla_computation wrap the jitted, pmapped, or sharded_jitted function rather than standing in for the jit/pmap/sharded_jit.

@skye
Copy link
Collaborator Author

skye commented Jul 15, 2020

Agreed, I like that idea. This is easier for now though.

@skye skye merged commit dbc3f83 into google:master Jul 15, 2020
skye added a commit to skye/jax that referenced this pull request Jul 16, 2020
…mputation`. (google#3771)"

This reverts commit dbc3f83.

This is breaking some google-internal users of xla_computation. Reverting while I investigate.
skye added a commit that referenced this pull request Jul 16, 2020
…mputation`. (#3771)" (#3780)

This reverts commit dbc3f83.

This is breaking some google-internal users of xla_computation. Reverting while I investigate.
NeilGirdhar pushed a commit to NeilGirdhar/jax that referenced this pull request Jul 19, 2020
…n`. (google#3771)

This allows partitioned computations in `xla_computation`, like those produced by `sharded_jit`.
NeilGirdhar pushed a commit to NeilGirdhar/jax that referenced this pull request Jul 19, 2020
…mputation`. (google#3771)" (google#3780)

This reverts commit dbc3f83.

This is breaking some google-internal users of xla_computation. Reverting while I investigate.
skye added a commit to skye/jax that referenced this pull request Jul 22, 2020
…n`. (google#3771)

This allows partitioned computations in `xla_computation`, like those produced by `sharded_jit`.
NeilGirdhar pushed a commit to NeilGirdhar/jax that referenced this pull request Jul 24, 2020
…n`. (google#3771)

This allows partitioned computations in `xla_computation`, like those produced by `sharded_jit`.
NeilGirdhar pushed a commit to NeilGirdhar/jax that referenced this pull request Jul 24, 2020
…mputation`. (google#3771)" (google#3780)

This reverts commit dbc3f83.

This is breaking some google-internal users of xla_computation. Reverting while I investigate.
NeilGirdhar pushed a commit to NeilGirdhar/jax that referenced this pull request Jul 24, 2020
…n`. (google#3771)

This allows partitioned computations in `xla_computation`, like those produced by `sharded_jit`.
NeilGirdhar pushed a commit to NeilGirdhar/jax that referenced this pull request Jul 24, 2020
…mputation`. (google#3771)" (google#3780)

This reverts commit dbc3f83.

This is breaking some google-internal users of xla_computation. Reverting while I investigate.
rsepassi pushed a commit to rsepassi/jax that referenced this pull request Aug 14, 2020
rsepassi pushed a commit to rsepassi/jax that referenced this pull request Aug 14, 2020
PR google#3771 redux (reverted in google#3780)

Co-authored-by: Skye Wanderman-Milne <skyewm@google.com>
skye added a commit that referenced this pull request Aug 14, 2020
…n`. (#4055)

PR #3771 redux (reverted in #3780)

Co-authored-by: Skye Wanderman-Milne <skyewm@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants