Skip to content
Permalink
Tree: f0df5c1be1
Commits on Sep 3, 2019
  1. usb, kcov: annotate hub_event

    xairy committed Jan 17, 2019
    Signed-off-by: Andrey Konovalov <andreyknvl@google.com>
  2. kcov: remote coverage support

    xairy committed Jan 17, 2019
    Signed-off-by: Andrey Konovalov <andreyknvl@google.com>
Commits on Sep 2, 2019
  1. Merge 5.3-rc7 into usb-next

    gregkh committed Sep 2, 2019
    We need the usb fixes in here for testing
    
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  2. Merge tag 'usb-for-v5.4' of git://git.kernel.org/pub/scm/linux/kernel…

    gregkh committed Sep 2, 2019
    …/git/balbi/usb into usb-next
    
    Felipe writes:
    
    USB: Changes for v5.4 merge window
    
    With only 45 non-merge commits, we have a small merge window from the
    Gadget perspective.
    
    The biggest change here is the addition of the Cadence USB3 DRD
    Driver. All other changes are small, non-critical fixes or smaller new
    features like the improvement to BESL handling in dwc3.
    
    Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
    
    * tag 'usb-for-v5.4' of git://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb: (45 commits)
      usb: gadget: net2280: Add workaround for AB chip Errata 11
      usb: gadget: net2280: Move all "ll" registers in one structure
      usb: dwc3: gadget: Workaround Mirosoft's BESL check
      usb:cdns3 Fix for stuck packets in on-chip OUT buffer.
      usb: cdns3: Add Cadence USB3 DRD Driver
      usb: common: Simplify usb_decode_get_set_descriptor function.
      usb: common: Patch simplify usb_decode_set_clear_feature function.
      usb: common: Separated decoding functions from dwc3 driver.
      dt-bindings: add binding for USBSS-DRD controller.
      usb: gadget: composite: Set recommended BESL values
      usb: dwc3: gadget: Set BESL config parameter
      usb: dwc3: Separate field holding multiple properties
      usb: gadget: Export recommended BESL values
      usb: phy: phy-fsl-usb: Make structure fsl_otg_initdata constant
      usb: udc: lpc32xx: silence fall-through warning
      usb: dwc3: meson-g12a: fix suspend resume regulator unbalanced disables
      usb: udc: lpc32xx: remove set but not used 3 variables
      usb: gadget: udc: core: Fix segfault if udc_bind_to_driver() for pending driver fails
      usb: dwc3: st: Add of_dev_put() in probe function
      usb: dwc3: st: Add of_node_put() before return in probe function
      ...
  3. Linux 5.3-rc7

    torvalds committed Sep 2, 2019
  4. Merge tag 'char-misc-5.3-rc7' of git://git.kernel.org/pub/scm/linux/k…

    torvalds committed Sep 2, 2019
    …ernel/git/gregkh/char-misc
    
    Pull char/misc driver fixes from Greg KH:
     "Here are some small char and misc driver fixes for reported issues for
      5.3-rc7
    
      Also included in here is the documentation for how we are handling
      hardware issues under embargo that everyone has finally agreed on, as
      well as a MAINTAINERS update for the suckers who agreed to handle the
      LICENSES/ files.
    
      All of these have been in linux-next last week with no reported
      issues"
    
    * tag 'char-misc-5.3-rc7' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc:
      fsi: scom: Don't abort operations for minor errors
      vmw_balloon: Fix offline page marking with compaction
      VMCI: Release resource if the work is already queued
      Documentation/process: Embargoed hardware security issues
      lkdtm/bugs: fix build error in lkdtm_EXHAUST_STACK
      mei: me: add Tiger Lake point LP device ID
      intel_th: pci: Add Tiger Lake support
      intel_th: pci: Add support for another Lewisburg PCH
      stm class: Fix a double free of stm_source_device
      MAINTAINERS: add entry for LICENSES and SPDX stuff
      fpga: altera-ps-spi: Fix getting of optional confd gpio
  5. Merge tag 'usb-5.3-rc7' of git://git.kernel.org/pub/scm/linux/kernel/…

    torvalds committed Sep 2, 2019
    …git/gregkh/usb
    
    Pull USB fixes from Greg KH:
     "Here are some small USB fixes that have been in linux-next this past
      week for 5.3-rc7
    
      They fix the usual xhci, syzbot reports, and other small issues that
      have come up last week.
    
      All have been in linux-next with no reported issues"
    
    * tag 'usb-5.3-rc7' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb:
      USB: cdc-wdm: fix race between write and disconnect due to flag abuse
      usb: host: xhci: rcar: Fix typo in compatible string matching
      usb: host: xhci-tegra: Set DMA mask correctly
      USB: storage: ums-realtek: Whitelist auto-delink support
      USB: storage: ums-realtek: Update module parameter description for auto_delink_en
      usb: host: ohci: fix a race condition between shutdown and irq
      usb: hcd: use managed device resources
      typec: tcpm: fix a typo in the comparison of pdo_max_voltage
      usb-storage: Add new JMS567 revision to unusual_devs
      usb: chipidea: udc: don't do hardware access if gadget has stopped
      usbtmc: more sanity checking for packet size
      usb: udc: lpc32xx: silence fall-through warning
  6. Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net

    torvalds committed Sep 2, 2019
    Pull networking fixes from David Miller:
    
     1) Fix some length checks during OGM processing in batman-adv, from
        Sven Eckelmann.
    
     2) Fix regression that caused netfilter conntrack sysctls to not be
        per-netns any more. From Florian Westphal.
    
     3) Use after free in netpoll, from Feng Sun.
    
     4) Guard destruction of pfifo_fast per-cpu qdisc stats with
        qdisc_is_percpu_stats(), from Davide Caratti. Similar bug is fixed
        in pfifo_fast_enqueue().
    
     5) Fix memory leak in mld_del_delrec(), from Eric Dumazet.
    
     6) Handle neigh events on internal ports correctly in nfp, from John
        Hurley.
    
     7) Clear SKB timestamp in NF flow table code so that it does not
        confuse fq scheduler. From Florian Westphal.
    
     8) taprio destroy can crash if it is invoked in a failure path of
        taprio_init(), because the list head isn't setup properly yet and
        the list del is unconditional. Perform the list add earlier to
        address this. From Vladimir Oltean.
    
     9) Make sure to reapply vlan filters on device up, in aquantia driver.
        From Dmitry Bogdanov.
    
    10) sgiseeq driver releases DMA memory using free_page() instead of
        dma_free_attrs(). From Christophe JAILLET.
    
    * git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net: (58 commits)
      net: seeq: Fix the function used to release some memory in an error handling path
      enetc: Add missing call to 'pci_free_irq_vectors()' in probe and remove functions
      net: bcmgenet: use ethtool_op_get_ts_info()
      tc-testing: don't hardcode 'ip' in nsPlugin.py
      net: dsa: microchip: add KSZ8563 compatibility string
      dt-bindings: net: dsa: document additional Microchip KSZ8563 switch
      net: aquantia: fix out of memory condition on rx side
      net: aquantia: linkstate irq should be oneshot
      net: aquantia: reapply vlan filters on up
      net: aquantia: fix limit of vlan filters
      net: aquantia: fix removal of vlan 0
      net/sched: cbs: Set default link speed to 10 Mbps in cbs_set_port_rate
      taprio: Set default link speed to 10 Mbps in taprio_set_picos_per_byte
      taprio: Fix kernel panic in taprio_destroy
      net: dsa: microchip: fill regmap_config name
      rxrpc: Fix lack of conn cleanup when local endpoint is cleaned up [ver #2]
      net: stmmac: dwmac-rk: Don't fail if phy regulator is absent
      amd-xgbe: Fix error path in xgbe_mod_init()
      netfilter: nft_meta_bridge: Fix get NFT_META_BRI_IIFVPROTO in network byteorder
      mac80211: Correctly set noencrypt for PAE frames
      ...
Commits on Sep 1, 2019
  1. net: seeq: Fix the function used to release some memory in an error h…

    tititiou36 authored and davem330 committed Aug 31, 2019
    …andling path
    
    In commit 99cd149 ("sgiseeq: replace use of dma_cache_wback_inv"),
    a call to 'get_zeroed_page()' has been turned into a call to
    'dma_alloc_coherent()'. Only the remove function has been updated to turn
    the corresponding 'free_page()' into 'dma_free_attrs()'.
    The error hndling path of the probe function has not been updated.
    
    Fix it now.
    
    Rename the corresponding label to something more in line.
    
    Fixes: 99cd149 ("sgiseeq: replace use of dma_cache_wback_inv")
    Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
    Reviewed-by: Thomas Bogendoerfer <tbogendoerfer@suse.de>
    Signed-off-by: David S. Miller <davem@davemloft.net>
  2. Merge branch 'x86-urgent-for-linus' of git://git.kernel.org/pub/scm/l…

    torvalds committed Sep 1, 2019
    …inux/kernel/git/tip/tip
    
    Pull x86 fixes from Thomas Gleixner:
     "A set of fixes for x86:
    
       - Fix the bogus detection of 32bit user mode for uretprobes which
         caused corruption of the user return address resulting in
         application crashes. In the uprobes handler in_ia32_syscall() is
         obviously always returning false on a 64bit kernel. Use
         user_64bit_mode() instead which works correctly.
    
       - Prevent large page splitting when ftrace flips RW/RO on the kernel
         text which caused iTLB performance issues. Ftrace wants to be
         converted to text_poke() which avoids the problem, but for now
         allow large page preservation in the static protections check when
         the change request spawns a full large page.
    
       - Prevent arch_dynirq_lower_bound() from returning 0 when the IOAPIC
         is configured via device tree. In the device tree case the GSI 1:1
         mapping is meaningless therefore the lower bound which protects the
         GSI range on ACPI machines is irrelevant. Return the lower bound
         which the core hands to the function instead of blindly returning 0
         which causes the core to allocate the invalid virtual interupt
         number 0 which in turn prevents all drivers from allocating and
         requesting an interrupt.
    
       - Remove the bogus initialization of LDR and DFR in the 32bit bigsmp
         APIC driver. That uses physical destination mode where LDR/DFR are
         ignored, but the initialization and the missing clear of LDR caused
         the APIC to be left in a inconsistent state on kexec/reboot.
    
       - Clear LDR when clearing the APIC registers so the APIC is in a well
         defined state.
    
       - Initialize variables proper in the find_trampoline_placement()
         code.
    
       - Silence GCC( build warning for the real mode part of the build"
    
    * 'x86-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip:
      x86/mm/cpa: Prevent large page split when ftrace flips RW on kernel text
      x86/build: Add -Wnoaddress-of-packed-member to REALMODE_CFLAGS, to silence GCC9 build warning
      x86/boot/compressed/64: Fix missing initialization in find_trampoline_placement()
      x86/apic: Include the LDR when clearing out APIC registers
      x86/apic: Do not initialize LDR and DFR for bigsmp
      uprobes/x86: Fix detection of 32-bit user mode
      x86/apic: Fix arch_dynirq_lower_bound() bug for DT enabled machines
  3. Merge branch 'perf-urgent-for-linus' of git://git.kernel.org/pub/scm/…

    torvalds committed Sep 1, 2019
    …linux/kernel/git/tip/tip
    
    Pull perf fixes from Thomas Gleixner:
     "Two fixes for perf x86 hardware implementations:
    
       - Restrict the period on Nehalem machines to prevent perf from
         hogging the CPU
    
       - Prevent the AMD IBS driver from overwriting the hardwre controlled
         and pre-seeded reserved bits (0-6) in the count register which
         caused a sample bias for dispatched micro-ops"
    
    * 'perf-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip:
      perf/x86/amd/ibs: Fix sample bias for dispatched micro-ops
      perf/x86/intel: Restrict period on Nehalem
  4. Merge branch 'turbostat' of git://git.kernel.org/pub/scm/linux/kernel…

    torvalds committed Sep 1, 2019
    …/git/lenb/linux
    
    Pull turbostat updates from Len Brown:
     "User-space turbostat (and x86_energy_perf_policy) patches.
    
      They are primarily bug fixes from users"
    
    * 'turbostat' of git://git.kernel.org/pub/scm/linux/kernel/git/lenb/linux:
      tools/power turbostat: update version number
      tools/power turbostat: Add support for Hygon Fam 18h (Dhyana) RAPL
      tools/power turbostat: Fix caller parameter of get_tdp_amd()
      tools/power turbostat: Fix CPU%C1 display value
      tools/power turbostat: do not enforce 1ms
      tools/power turbostat: read from pipes too
      tools/power turbostat: Add Ice Lake NNPI support
      tools/power turbostat: rename has_hsw_msrs()
      tools/power turbostat: Fix Haswell Core systems
      tools/power turbostat: add Jacobsville support
      tools/power turbostat: fix buffer overrun
      tools/power turbostat: fix file descriptor leaks
      tools/power turbostat: fix leak of file descriptor on error return path
      tools/power turbostat: Make interval calculation per thread to reduce jitter
      tools/power turbostat: remove duplicate pc10 column
      tools/power x86_energy_perf_policy: Fix argument parsing
      tools/power: Fix typo in man page
      tools/power/x86: Enable compiler optimisations and Fortify by default
      tools/power x86_energy_perf_policy: Fix "uninitialized variable" warnings at -O2
  5. enetc: Add missing call to 'pci_free_irq_vectors()' in probe and remo…

    tititiou36 authored and davem330 committed Aug 30, 2019
    …ve functions
    
    Call to 'pci_free_irq_vectors()' are missing both in the error handling
    path of the probe function, and in the remove function.
    Add them.
    
    Fixes: 19971f5 ("enetc: add PTP clock driver")
    Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
    Signed-off-by: David S. Miller <davem@davemloft.net>
  6. net: bcmgenet: use ethtool_op_get_ts_info()

    Ryan M. Collins authored and davem330 committed Aug 30, 2019
    This change enables the use of SW timestamping on the Raspberry Pi 4.
    
    bcmgenet's transmit function bcmgenet_xmit() implements software
    timestamping. However the SOF_TIMESTAMPING_TX_SOFTWARE capability was
    missing and only SOF_TIMESTAMPING_RX_SOFTWARE was announced. By using
    ethtool_ops bcmgenet_ethtool_ops() as get_ts_info(), the
    SOF_TIMESTAMPING_TX_SOFTWARE capability is announced.
    
    Similar to commit a8f5cb9 ("smsc95xx: use ethtool_op_get_ts_info()")
    
    Signed-off-by: Ryan M. Collins <rmc032@bucknell.edu>
    Acked-by: Florian Fainelli <f.fainelli@gmail.com>
    Acked-by: Doug Berger <opendmb@gmail.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
  7. tc-testing: don't hardcode 'ip' in nsPlugin.py

    dcaratti authored and davem330 committed Aug 30, 2019
    the following tdc test fails on Fedora:
    
     # ./tdc.py -e 2638
      -- ns/SubPlugin.__init__
     Test 2638: Add matchall and try to get it
     -----> prepare stage *** Could not execute: "$TC qdisc add dev $DEV1 clsact"
     -----> prepare stage *** Error message: "/bin/sh: ip: command not found"
     returncode 127; expected [0]
     -----> prepare stage *** Aborting test run.
    
    Let nsPlugin.py use the 'IP' variable introduced with commit 92c1a19
    ("tc-tests: added path to ip command in tdc"), so that the path to 'ip' is
    correctly resolved to the value we have in tdc_config.py.
    
     # ./tdc.py -e 2638
      -- ns/SubPlugin.__init__
     Test 2638: Add matchall and try to get it
     All test results:
     1..1
     ok 1 2638 - Add matchall and try to get it
    
    Fixes: 489ce2f ("tc-testing: Restore original behaviour for namespaces in tdc")
    Reported-by: Hangbin Liu <liuhangbin@gmail.com>
    Signed-off-by: Davide Caratti <dcaratti@redhat.com>
    Acked-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
  8. Merge branch 'net-dsa-microchip-add-KSZ8563-support'

    davem330 committed Sep 1, 2019
    Razvan Stefanescu says:
    
    ====================
    net: dsa: microchip: add KSZ8563 support
    
    This patchset adds compatibility string for the KSZ8563 switch.
    ====================
    
    Signed-off-by: David S. Miller <davem@davemloft.net>
  9. net: dsa: microchip: add KSZ8563 compatibility string

    RazvanStef authored and davem330 committed Aug 30, 2019
    It is a 3-Port 10/100 Ethernet Switch with 1588v2 PTP.
    
    Signed-off-by: Razvan Stefanescu <razvan.stefanescu@microchip.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
  10. dt-bindings: net: dsa: document additional Microchip KSZ8563 switch

    RazvanStef authored and davem330 committed Aug 30, 2019
    It is a 3-Port 10/100 Ethernet Switch with 1588v2 PTP.
    
    Signed-off-by: Razvan Stefanescu <razvan.stefanescu@microchip.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
  11. Merge branch 'net-aquantia-fixes-on-vlan-filters-and-other-conditions'

    davem330 committed Sep 1, 2019
    Igor Russkikh says:
    
    ====================
    net: aquantia: fixes on vlan filters and other conditions
    
    Here is a set of various bug fixes related to vlan filter offload and
    two other rare cases.
    ====================
    
    Signed-off-by: David S. Miller <davem@davemloft.net>
  12. net: aquantia: fix out of memory condition on rx side

    logost authored and davem330 committed Aug 30, 2019
    On embedded environments with hard memory limits it is a normal although
    rare case when skb can't be allocated on rx part under high traffic.
    
    In such OOM cases napi_complete_done() was not called.
    So the napi object became in an invalid state like it is "scheduled".
    Kernel do not re-schedules the poll of that napi object.
    
    Consequently, kernel can not remove that object the system hangs on
    `ifconfig down` waiting for a poll.
    
    We are fixing this by gracefully closing napi poll routine with correct
    invocation of napi_complete_done.
    
    This was reproduced with artificially failing the allocation of skb to
    simulate an "out of memory" error case and check that traffic does
    not get stuck.
    
    Fixes: 970a2e9 ("net: ethernet: aquantia: Vector operations")
    Signed-off-by: Igor Russkikh <igor.russkikh@aquantia.com>
    Signed-off-by: Dmitry Bogdanov <dmitry.bogdanov@aquantia.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
  13. net: aquantia: linkstate irq should be oneshot

    cail authored and davem330 committed Aug 30, 2019
    Declaring threaded irq handler should also indicate the irq is
    oneshot. It is oneshot indeed, because HW implements irq automasking
    on trigger.
    
    Not declaring this causes some kernel configurations to fail
    on interface up, because request_threaded_irq returned an err code.
    
    The issue was originally hidden on normal x86_64 configuration with
    latest kernel, because depending on interrupt controller, irq driver
    added ONESHOT flag on its own.
    
    Issue was observed on older kernels (4.14) where no such logic exists.
    
    Fixes: 4c83f17 ("net: aquantia: link status irq handling")
    Signed-off-by: Igor Russkikh <igor.russkikh@aquantia.com>
    Reported-by: Michael Symolkin <Michael.Symolkin@aquantia.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
  14. net: aquantia: reapply vlan filters on up

    logost authored and davem330 committed Aug 30, 2019
    In case of device reconfiguration the driver may reset the device invisible
    for other modules, vlan module in particular. So vlans will not be
    removed&created and vlan filters will not be configured in the device.
    The patch reapplies the vlan filters at device start.
    
    Fixes: 7975d2a ("net: aquantia: add support of rx-vlan-filter offload")
    Signed-off-by: Dmitry Bogdanov <dmitry.bogdanov@aquantia.com>
    Signed-off-by: Igor Russkikh <igor.russkikh@aquantia.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
  15. net: aquantia: fix limit of vlan filters

    logost authored and davem330 committed Aug 30, 2019
    Fix a limit condition of vlans on the interface before setting vlan
    promiscuous mode
    
    Fixes: 48dd73d ("net: aquantia: fix vlans not working over bridged network")
    Signed-off-by: Dmitry Bogdanov <dmitry.bogdanov@aquantia.com>
    Signed-off-by: Igor Russkikh <igor.russkikh@aquantia.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
  16. net: aquantia: fix removal of vlan 0

    logost authored and davem330 committed Aug 30, 2019
    Due to absence of checking against the rx flow rule when vlan 0 is being
    removed, the other rule could be removed instead of the rule with vlan 0
    
    Fixes: 7975d2a ("net: aquantia: add support of rx-vlan-filter offload")
    Signed-off-by: Dmitry Bogdanov <dmitry.bogdanov@aquantia.com>
    Signed-off-by: Igor Russkikh <igor.russkikh@aquantia.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
  17. Merge branch 'Fix-issues-in-tc-taprio-and-tc-cbs'

    davem330 committed Sep 1, 2019
    Vladimir Oltean says:
    
    ====================
    Fix issues in tc-taprio and tc-cbs
    
    This series fixes one panic and one WARN_ON found in the tc-taprio
    qdisc, while trying to apply it:
    
    - On an interface which is not multi-queue
    - On an interface which has no carrier
    
    The tc-cbs was also visually found to suffer of the same issue as
    tc-taprio, and the fix was only compile-tested in that case.
    ====================
    
    Signed-off-by: David S. Miller <davem@davemloft.net>
  18. net/sched: cbs: Set default link speed to 10 Mbps in cbs_set_port_rate

    vladimiroltean authored and davem330 committed Aug 30, 2019
    The discussion to be made is absolutely the same as in the case of
    previous patch ("taprio: Set default link speed to 10 Mbps in
    taprio_set_picos_per_byte"). Nothing is lost when setting a default.
    
    Cc: Leandro Dorileo <leandro.maciel.dorileo@intel.com>
    Fixes: e0a7683 ("net/sched: cbs: fix port_rate miscalculation")
    Acked-by: Vinicius Costa Gomes <vinicius.gomes@intel.com>
    Signed-off-by: Vladimir Oltean <olteanv@gmail.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
  19. taprio: Set default link speed to 10 Mbps in taprio_set_picos_per_byte

    vladimiroltean authored and davem330 committed Aug 30, 2019
    The taprio budget needs to be adapted at runtime according to interface
    link speed. But that handling is problematic.
    
    For one thing, installing a qdisc on an interface that doesn't have
    carrier is not illegal. But taprio prints the following stack trace:
    
    [   31.851373] ------------[ cut here ]------------
    [   31.856024] WARNING: CPU: 1 PID: 207 at net/sched/sch_taprio.c:481 taprio_dequeue+0x1a8/0x2d4
    [   31.864566] taprio: dequeue() called with unknown picos per byte.
    [   31.864570] Modules linked in:
    [   31.873701] CPU: 1 PID: 207 Comm: tc Not tainted 5.3.0-rc5-01199-g8838fe023cd6 #1689
    [   31.881398] Hardware name: Freescale LS1021A
    [   31.885661] [<c03133a4>] (unwind_backtrace) from [<c030d8cc>] (show_stack+0x10/0x14)
    [   31.893368] [<c030d8cc>] (show_stack) from [<c10ac958>] (dump_stack+0xb4/0xc8)
    [   31.900555] [<c10ac958>] (dump_stack) from [<c0349d04>] (__warn+0xe0/0xf8)
    [   31.907395] [<c0349d04>] (__warn) from [<c0349d64>] (warn_slowpath_fmt+0x48/0x6c)
    [   31.914841] [<c0349d64>] (warn_slowpath_fmt) from [<c0f38db4>] (taprio_dequeue+0x1a8/0x2d4)
    [   31.923150] [<c0f38db4>] (taprio_dequeue) from [<c0f227b0>] (__qdisc_run+0x90/0x61c)
    [   31.930856] [<c0f227b0>] (__qdisc_run) from [<c0ec82ac>] (net_tx_action+0x12c/0x2bc)
    [   31.938560] [<c0ec82ac>] (net_tx_action) from [<c0302298>] (__do_softirq+0x130/0x3c8)
    [   31.946350] [<c0302298>] (__do_softirq) from [<c03502a0>] (irq_exit+0xbc/0xd8)
    [   31.953536] [<c03502a0>] (irq_exit) from [<c03a4808>] (__handle_domain_irq+0x60/0xb4)
    [   31.961328] [<c03a4808>] (__handle_domain_irq) from [<c0754478>] (gic_handle_irq+0x58/0x9c)
    [   31.969638] [<c0754478>] (gic_handle_irq) from [<c0301a8c>] (__irq_svc+0x6c/0x90)
    [   31.977076] Exception stack(0xe8167b20 to 0xe8167b68)
    [   31.982100] 7b20: e9d4bd80 00000cc0 000000cf 00000000 e9d4bd80 c1f38958 00000cc0 c1f38960
    [   31.990234] 7b40: 00000001 000000cf 00000004 e9dc0800 00000000 e8167b70 c0f478ec c0f46d94
    [   31.998363] 7b60: 60070013 ffffffff
    [   32.001833] [<c0301a8c>] (__irq_svc) from [<c0f46d94>] (netlink_trim+0x18/0xd8)
    [   32.009104] [<c0f46d94>] (netlink_trim) from [<c0f478ec>] (netlink_broadcast_filtered+0x34/0x414)
    [   32.017930] [<c0f478ec>] (netlink_broadcast_filtered) from [<c0f47cec>] (netlink_broadcast+0x20/0x28)
    [   32.027102] [<c0f47cec>] (netlink_broadcast) from [<c0eea378>] (rtnetlink_send+0x34/0x88)
    [   32.035238] [<c0eea378>] (rtnetlink_send) from [<c0f25890>] (notify_and_destroy+0x2c/0x44)
    [   32.043461] [<c0f25890>] (notify_and_destroy) from [<c0f25e08>] (qdisc_graft+0x398/0x470)
    [   32.051595] [<c0f25e08>] (qdisc_graft) from [<c0f27a00>] (tc_modify_qdisc+0x3a4/0x724)
    [   32.059470] [<c0f27a00>] (tc_modify_qdisc) from [<c0ee4c84>] (rtnetlink_rcv_msg+0x260/0x2ec)
    [   32.067864] [<c0ee4c84>] (rtnetlink_rcv_msg) from [<c0f4a988>] (netlink_rcv_skb+0xb8/0x110)
    [   32.076172] [<c0f4a988>] (netlink_rcv_skb) from [<c0f4a170>] (netlink_unicast+0x1b4/0x22c)
    [   32.084392] [<c0f4a170>] (netlink_unicast) from [<c0f4a5e4>] (netlink_sendmsg+0x33c/0x380)
    [   32.092614] [<c0f4a5e4>] (netlink_sendmsg) from [<c0ea9f40>] (sock_sendmsg+0x14/0x24)
    [   32.100403] [<c0ea9f40>] (sock_sendmsg) from [<c0eaa780>] (___sys_sendmsg+0x214/0x228)
    [   32.108279] [<c0eaa780>] (___sys_sendmsg) from [<c0eabad0>] (__sys_sendmsg+0x50/0x8c)
    [   32.116068] [<c0eabad0>] (__sys_sendmsg) from [<c0301000>] (ret_fast_syscall+0x0/0x54)
    [   32.123938] Exception stack(0xe8167fa8 to 0xe8167ff0)
    [   32.128960] 7fa0:                   b6fa68c8 000000f8 00000003 bea142d0 00000000 00000000
    [   32.137093] 7fc0: b6fa68c8 000000f8 0052154c 00000128 5d6468a2 00000000 00000028 00558c9c
    [   32.145224] 7fe0: 00000070 bea14278 00530d64 b6e17e64
    [   32.150659] ---[ end trace 2139c9827c3e5177 ]---
    
    This happens because the qdisc ->dequeue callback gets called. Which
    again is not illegal, the qdisc will dequeue even when the interface is
    up but doesn't have carrier (and hence SPEED_UNKNOWN), and the frames
    will be dropped further down the stack in dev_direct_xmit().
    
    And, at the end of the day, for what? For calculating the initial budget
    of an interface which is non-operational at the moment and where frames
    will get dropped anyway.
    
    So if we can't figure out the link speed, default to SPEED_10 and move
    along. We can also remove the runtime check now.
    
    Cc: Leandro Dorileo <leandro.maciel.dorileo@intel.com>
    Fixes: 7b9eba7 ("net/sched: taprio: fix picos_per_byte miscalculation")
    Acked-by: Vinicius Costa Gomes <vinicius.gomes@intel.com>
    Signed-off-by: Vladimir Oltean <olteanv@gmail.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
  20. taprio: Fix kernel panic in taprio_destroy

    vladimiroltean authored and davem330 committed Aug 30, 2019
    taprio_init may fail earlier than this line:
    
    	list_add(&q->taprio_list, &taprio_list);
    
    i.e. due to the net device not being multi queue.
    
    Attempting to remove q from the global taprio_list when it is not part
    of it will result in a kernel panic.
    
    Fix it by matching list_add and list_del better to one another in the
    order of operations. This way we can keep the deletion unconditional
    and with lower complexity - O(1).
    
    Cc: Leandro Dorileo <leandro.maciel.dorileo@intel.com>
    Fixes: 7b9eba7 ("net/sched: taprio: fix picos_per_byte miscalculation")
    Signed-off-by: Vladimir Oltean <olteanv@gmail.com>
    Acked-by: Vinicius Costa Gomes <vinicius.gomes@intel.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
Commits on Aug 31, 2019
  1. net: dsa: microchip: fill regmap_config name

    gmccollister authored and davem330 committed Aug 29, 2019
    Use the register value width as the regmap_config name to prevent the
    following error when the second and third regmap_configs are
    initialized.
     "debugfs: Directory '${bus-id}' with parent 'regmap' already present!"
    
    Signed-off-by: George McCollister <george.mccollister@gmail.com>
    Reviewed-by: Marek Vasut <marex@denx.de>
    Signed-off-by: David S. Miller <davem@davemloft.net>
  2. Merge tag 'batadv-net-for-davem-20190830' of git://git.open-mesh.org/…

    davem330 committed Aug 31, 2019
    …linux-merge
    
    Simon Wunderlich says:
    
    ====================
    Here are two batman-adv bugfixes:
    
     - Fix OGM and OGMv2 header read boundary check,
       by Sven Eckelmann (2 patches)
    ====================
    
    Signed-off-by: David S. Miller <davem@davemloft.net>
  3. tools/power turbostat: update version number

    lenb committed Aug 31, 2019
    Today is 19.08.31, at least in some parts of the world.
    
    Signed-off-by: Len Brown <len.brown@intel.com>
  4. tools/power turbostat: Add support for Hygon Fam 18h (Dhyana) RAPL

    Pu Wen authored and lenb committed Aug 31, 2019
    Commit 9392bd9 ("tools/power turbostat: Add support for AMD
    Fam 17h (Zen) RAPL") and the commit 3316f99 ("tools/power
    turbostat: Also read package power on AMD F17h (Zen)") add AMD Fam 17h
    RAPL support.
    
    Hygon Family 18h(Dhyana) support RAPL in bit 14 of CPUID 0x80000007 EDX,
    and has MSRs RAPL_PWR_UNIT/CORE_ENERGY_STAT/PKG_ENERGY_STAT. So add Hygon
    Dhyana Family 18h support for RAPL.
    
    Already tested on Hygon multi-node systems and it shows correct per-core
    energy usage and the total package power.
    
    Signed-off-by: Pu Wen <puwen@hygon.cn>
    Reviewed-by: Calvin Walton <calvin.walton@kepstin.ca>
    Signed-off-by: Len Brown <len.brown@intel.com>
  5. tools/power turbostat: Fix caller parameter of get_tdp_amd()

    Pu Wen authored and lenb committed Aug 31, 2019
    Commit 9392bd9 ("tools/power turbostat: Add support for AMD
    Fam 17h (Zen) RAPL") add a function get_tdp_amd(), the parameter is CPU
    family. But the rapl_probe_amd() function use wrong model parameter.
    Fix the wrong caller parameter of get_tdp_amd() to use family.
    
    Cc: <stable@vger.kernel.org> # v5.1+
    Signed-off-by: Pu Wen <puwen@hygon.cn>
    Reviewed-by: Calvin Walton <calvin.walton@kepstin.ca>
    Signed-off-by: Len Brown <len.brown@intel.com>
  6. tools/power turbostat: Fix CPU%C1 display value

    spandruvada authored and lenb committed Aug 27, 2019
    In some case C1% will be wrong value, when platform doesn't have MSR for
    C1 residency.
    
    For example:
    Core    CPU     CPU%c1
    -       -       100.00
    0       0       100.00
    0       2       100.00
    1       1       100.00
    1       3       100.00
    
    But adding Busy% will fix this
    Core    CPU     Busy%   CPU%c1
    -       -       99.77   0.23
    0       0       99.77   0.23
    0       2       99.77   0.23
    1       1       99.77   0.23
    1       3       99.77   0.23
    
    This issue can be reproduced on most of the recent systems including
    Broadwell, Skylake and later.
    
    This is because if we don't select Busy% or Avg_MHz or Bzy_MHz then
    mperf value will not be read from MSR, so it will be 0. But this
    is required for C1% calculation when MSR for C1 residency is not present.
    Same is true for C3, C6 and C7 column selection.
    
    So add another define DO_BIC_READ(), which doesn't depend on user
    column selection and use for mperf, C3, C6 and C7 related counters.
    So when there is no platform support for C1 residency counters,
    we still read these counters, if the CPU has support and user selected
    display of CPU%c1.
    
    Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
    Signed-off-by: Len Brown <len.brown@intel.com>
Older
You can’t perform that action at this time.