Skip to content
This repository has been archived by the owner. It is now read-only.

Add integration test to code coverage metrics #1010

Merged
merged 3 commits into from Jul 6, 2018

Conversation

@gdbelvin
Copy link
Contributor

@gdbelvin gdbelvin commented Jul 5, 2018

Go 1.10 removes the need to run each test separately with the -coverprofile flag.

This also makes it easier to set environment variables for tests.

Go 1.10 removes the need to run each test separately with the
-coverprofile flag.
@codecov
Copy link

@codecov codecov bot commented Jul 5, 2018

Codecov Report

Merging #1010 into master will increase coverage by 0.38%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1010      +/-   ##
==========================================
+ Coverage   46.88%   47.26%   +0.38%     
==========================================
  Files          30       45      +15     
  Lines        2244     4356    +2112     
==========================================
+ Hits         1052     2059    +1007     
- Misses       1001     1981     +980     
- Partials      191      316     +125
Impacted Files Coverage Δ
core/fake/domain_storage.go 0% <0%> (ø)
core/fake/mutation_storage.go 0% <0%> (ø)
core/testutil/tink.go 76.81% <0%> (ø)
.../v1/keytransparency_go_proto/keytransparency.pb.go 48.68% <0%> (ø)
impl/authorization/authz_go_proto/authz.pb.go 12.76% <0%> (ø)
core/api/type/type_go_proto/type.pb.go 9.67% <0%> (ø)
...ore/api/v1/keytransparency_go_proto/admin.pb.gw.go 0% <0%> (ø)
core/fake/monitorstorage.go 66.66% <0%> (ø)
core/api/type/type_go_proto/keymaster.pb.go 10.81% <0%> (ø)
core/integration/monitor_tests.go 72.85% <0%> (ø)
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa51994...7744a84. Read the comment docs.

@gdbelvin gdbelvin requested a review from Martin2112 Jul 5, 2018
@gdbelvin gdbelvin changed the title Remove parallel from travis build script. Add integration test to code coverage metrics Jul 5, 2018
codecovio automatically merges coverage profiles
@gdbelvin gdbelvin merged commit 6c6f87b into google:master Jul 6, 2018
5 checks passed
5 checks passed
GolangCI No issues found!
Details
@googlebot
cla/google All necessary CLAs are signed
@codecov
codecov/patch Coverage not affected when comparing aa51994...7744a84
Details
@codecov
codecov/project 47.26% (+0.38%) compared to aa51994
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@gdbelvin gdbelvin deleted the gdbelvin:test/coverage branch Jul 6, 2018
gdbelvin added a commit to gdbelvin/keytransparency that referenced this pull request Jul 6, 2018
* master:
  Add integration test to code coverage metrics (google#1010)
  Main Title format fixed (google#1007)
  Fix queue deadlock (google#1006)
  Fix title format on google#5 (google#1008)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants