New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore generated files in code coverage stats #1017

Merged
merged 1 commit into from Jul 10, 2018

Conversation

Projects
None yet
2 participants
@gdbelvin
Collaborator

gdbelvin commented Jul 10, 2018

No description provided.

@gdbelvin gdbelvin requested a review from jtoohill Jul 10, 2018

@codecov

This comment has been minimized.

codecov bot commented Jul 10, 2018

Codecov Report

Merging #1017 into master will increase coverage by 17.78%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1017       +/-   ##
===========================================
+ Coverage   46.28%   64.07%   +17.78%     
===========================================
  Files          45       38        -7     
  Lines        4459     2650     -1809     
===========================================
- Hits         2064     1698      -366     
+ Misses       2080      654     -1426     
+ Partials      315      298       -17
Impacted Files Coverage Δ
...ore/api/v1/keytransparency_go_proto/admin.pb.gw.go
impl/authorization/authz_go_proto/authz.pb.go
.../keytransparency_go_proto/keytransparency.pb.gw.go
.../v1/keytransparency_go_proto/keytransparency.pb.go
core/api/v1/keytransparency_go_proto/admin.pb.go
core/api/type/type_go_proto/keymaster.pb.go
core/api/type/type_go_proto/type.pb.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7691fd2...5e191a5. Read the comment docs.

@gdbelvin gdbelvin merged commit 74ce88b into google:master Jul 10, 2018

5 checks passed

GolangCI No issues found!
Details
cla/google All necessary CLAs are signed
codecov/patch Coverage not affected when comparing 7691fd2...5e191a5
Details
codecov/project 64.07% (+17.78%) compared to 7691fd2
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@gdbelvin gdbelvin deleted the gdbelvin:codecovio branch Jul 10, 2018

gdbelvin added a commit to gdbelvin/keytransparency that referenced this pull request Jul 12, 2018

Merge branch 'master' into test/linter
* master:
  Generic load test (google#993)
  Split the sequencer into a caller and a grpc server (google#1014)
  Ignore generated files in code coverage (google#1017)
  Explicitly trust the first observed log root (google#1016)
  Use tink.Keyset for usermanager (google#1011)

gdbelvin added a commit to gdbelvin/keytransparency that referenced this pull request Jul 18, 2018

Merge branch 'master' into f/election
* master:
  Add golangci config (google#1013)
  Generic load test (google#993)
  Split the sequencer into a caller and a grpc server (google#1014)
  Ignore generated files in code coverage (google#1017)
  Explicitly trust the first observed log root (google#1016)
  Use tink.Keyset for usermanager (google#1011)
  Update protos (google#1012)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment