New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CONIKS_SHA256 hash strategy by default #1030

Merged
merged 1 commit into from Sep 4, 2018

Conversation

Projects
None yet
2 participants
@jtoohill
Collaborator

jtoohill commented Aug 31, 2018

Added to Trillian in google/trillian#1266. Also regenerates test vectors with the new hash strategy.

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Aug 31, 2018

Codecov Report

Merging #1030 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1030   +/-   ##
=======================================
  Coverage   66.01%   66.01%           
=======================================
  Files          39       39           
  Lines        2742     2742           
=======================================
  Hits         1810     1810           
  Misses        613      613           
  Partials      319      319
Impacted Files Coverage Δ
core/adminserver/admin_server.go 67.4% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac833bf...0eddf60. Read the comment docs.

codecov bot commented Aug 31, 2018

Codecov Report

Merging #1030 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1030   +/-   ##
=======================================
  Coverage   66.01%   66.01%           
=======================================
  Files          39       39           
  Lines        2742     2742           
=======================================
  Hits         1810     1810           
  Misses        613      613           
  Partials      319      319
Impacted Files Coverage Δ
core/adminserver/admin_server.go 67.4% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac833bf...0eddf60. Read the comment docs.

@jtoohill jtoohill requested a review from gdbelvin Sep 4, 2018

@gdbelvin

Please also add test vectors to the trillian/hashers/coniks package

@jtoohill jtoohill merged commit 6875ae0 into google:master Sep 4, 2018

5 checks passed

GolangCI No issues found!
Details
cla/google All necessary CLAs are signed
codecov/patch Coverage not affected when comparing ac833bf...0eddf60
Details
codecov/project 66.01% remains the same compared to ac833bf
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment