New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing argument to NewMapEnv #1035

Merged
merged 1 commit into from Sep 11, 2018

Conversation

Projects
None yet
3 participants
@jtoohill
Collaborator

jtoohill commented Sep 10, 2018

google/trillian#1272 added an experimental argument to NewMapEnv. Fixes adminserver and integration build errors.

Jon Toohill
Add missing argument to NewMapEnv
google/trillian#1272 added an experimental argument to NewMapEnv. Fixes adminserver and integration build errors.

@jtoohill jtoohill requested a review from gdbelvin Sep 10, 2018

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Sep 10, 2018

Codecov Report

Merging #1035 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1035   +/-   ##
=======================================
  Coverage   66.01%   66.01%           
=======================================
  Files          39       39           
  Lines        2742     2742           
=======================================
  Hits         1810     1810           
  Misses        613      613           
  Partials      319      319
Impacted Files Coverage Δ
impl/integration/env.go 72.58% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0e127b...ba62c76. Read the comment docs.

codecov bot commented Sep 10, 2018

Codecov Report

Merging #1035 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1035   +/-   ##
=======================================
  Coverage   66.01%   66.01%           
=======================================
  Files          39       39           
  Lines        2742     2742           
=======================================
  Hits         1810     1810           
  Misses        613      613           
  Partials      319      319
Impacted Files Coverage Δ
impl/integration/env.go 72.58% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0e127b...ba62c76. Read the comment docs.

@gdbelvin

This comment has been minimized.

Show comment
Hide comment
@gdbelvin

gdbelvin Sep 11, 2018

Collaborator

Thanks for catching this.

Collaborator

gdbelvin commented Sep 11, 2018

Thanks for catching this.

@AlCutter

This comment has been minimized.

Show comment
Hide comment
@AlCutter

AlCutter Sep 11, 2018

Thanks, and sorry for the breakage.

AlCutter commented Sep 11, 2018

Thanks, and sorry for the breakage.

@gdbelvin gdbelvin merged commit 55375b2 into google:master Sep 11, 2018

5 checks passed

GolangCI No issues found!
Details
cla/google All necessary CLAs are signed
codecov/patch 100% of diff hit (target 66.01%)
Details
codecov/project 66.01% (+0%) compared to 12b7a21
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jtoohill jtoohill deleted the jtoohill:fix-kt branch Sep 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment