Skip to content

/ keytransparency

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Makefile and use standard gometalinter config #1042

Merged
merged 2 commits into from Sep 19, 2018
Merged

Remove Makefile and use standard gometalinter config #1042

merged 2 commits into from Sep 19, 2018

Conversation

@gdbelvin
Copy link
Contributor

@gdbelvin gdbelvin commented Sep 17, 2018 •
edited

  • Removing the Makefile resolves #411. The go standard tools are better understood and usable.
  • Use the default config file for gometalinter.
gdbelvin added 2 commits Sep 17, 2018
@gdbelvin
Move gometalinter to standard path
Loading status checks…
4c40cad 
GoMetaLinter now supports a default config file of .gometalinter.json

https://github.com/alecthomas/gometalinter#configuration-file
@gdbelvin
Remove Makefile in favor of standard go tools
Loading status checks…
562b525
@gdbelvin gdbelvin requested review from cesarghali and RJPercival Sep 17, 2018
@gdbelvin gdbelvin changed the title Remove Makefile in favor of standard go tools Remove Makefile and use standard gometalinter config Sep 19, 2018
@RJPercival
RJPercival approved these changes Sep 19, 2018
View changes
Copy link
Contributor

@RJPercival RJPercival left a comment

LGTM. Could you also copy across the description from PR #1041 please?
@RJPercival
Copy link
Contributor

@RJPercival RJPercival commented Sep 19, 2018

Never mind, I see that you just did 🙂
@gdbelvin gdbelvin merged commit fe88b28 into google:master Sep 19, 2018
5 checks passed
5 checks passed
GolangCI No issues found!
Details
cla/google All necessary CLAs are signed
codecov/patch Coverage not affected when comparing 5bc02e8...562b525
Details
codecov/project 66.01% remains the same compared to 5bc02e8
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@gdbelvin gdbelvin deleted the gdbelvin:makefile branch Sep 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RJPercival RJPercival

@cesarghali cesarghali

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Remove Makefile once the repo is public.
2 participants
@gdbelvin @RJPercival
You can’t perform that action at this time.