New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gcloud install and deploy script #1060

Merged
merged 6 commits into from Oct 9, 2018

Conversation

Projects
None yet
2 participants
@gdbelvin
Collaborator

gdbelvin commented Oct 8, 2018

Update the gcloud install script.

For some reason, the main build was erroring with

gcloud compoenents install kubeclt was erroring with
ERROR: (gcloud.components.install) You cannot perform this action because this Cloud SDK installation is managed by an external package manager.
Please consider using a separate installation of the Cloud SDK created through the default mechanism described at: https://cloud.google.com/sdk/
  • Install via wget and ./install.sh.
  • Update the authentication keys while we're at it.

gdbelvin added some commits Oct 8, 2018

Download gcloud sdk
gcloud compoenents install kubeclt was erroring with
ERROR: (gcloud.components.install) You cannot perform this action because this Cloud SDK installation is managed by an external package manager.
Please consider using a separate installation of the Cloud SDK created through the default mechanism described at: https://cloud.google.com/sdk/

Migrate to apt-get based install to be compatible with Ubuntu docker image.

@google google deleted a comment from codecov bot Oct 8, 2018

@gdbelvin gdbelvin requested a review from AlCutter Oct 8, 2018

@gdbelvin gdbelvin changed the title from Update client_secret to Fix gcloud install and deploy script Oct 8, 2018

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Oct 8, 2018

Codecov Report

Merging #1060 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1060   +/-   ##
=======================================
  Coverage   65.16%   65.16%           
=======================================
  Files          39       39           
  Lines        2733     2733           
=======================================
  Hits         1781     1781           
  Misses        632      632           
  Partials      320      320

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb5cf0e...8e01baa. Read the comment docs.

codecov bot commented Oct 8, 2018

Codecov Report

Merging #1060 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1060   +/-   ##
=======================================
  Coverage   65.16%   65.16%           
=======================================
  Files          39       39           
  Lines        2733     2733           
=======================================
  Hits         1781     1781           
  Misses        632      632           
  Partials      320      320

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb5cf0e...8e01baa. Read the comment docs.

@AlCutter

Few minor suggestions

Show resolved Hide resolved .travis.yml Outdated
Show resolved Hide resolved .travis.yml Outdated
Show outdated Hide outdated .travis.yml Outdated
Show outdated Hide outdated .travis.yml Outdated
@gdbelvin

This comment has been minimized.

Show comment
Hide comment
@gdbelvin

gdbelvin Oct 8, 2018

Collaborator

Cleaned up the nits. PTAL

Collaborator

gdbelvin commented Oct 8, 2018

Cleaned up the nits. PTAL

@gdbelvin gdbelvin merged commit a2c69e0 into google:master Oct 9, 2018

5 checks passed

GolangCI No issues found!
Details
cla/google All necessary CLAs are signed
codecov/patch Coverage not affected when comparing fb5cf0e...8e01baa
Details
codecov/project 65.16% remains the same compared to fb5cf0e
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@gdbelvin gdbelvin deleted the gdbelvin:fix-travis branch Oct 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment