New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tink: move registry initialization to init #1061

Merged
merged 3 commits into from Oct 9, 2018

Conversation

Projects
None yet
2 participants
@gdbelvin
Collaborator

gdbelvin commented Oct 9, 2018

@gdbelvin gdbelvin requested a review from taknira Oct 9, 2018

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Oct 9, 2018

Codecov Report

Merging #1061 into master will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1061      +/-   ##
==========================================
+ Coverage   65.16%   65.24%   +0.08%     
==========================================
  Files          39       39              
  Lines        2733     2728       -5     
==========================================
- Hits         1781     1780       -1     
+ Misses        632      630       -2     
+ Partials      320      318       -2
Impacted Files Coverage Δ
core/mutator/entry/mutator.go 67.24% <ø> (+1.66%) ⬆️
core/integration/client_tests.go 85.26% <ø> (+0.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fd8ff9...0c31998. Read the comment docs.

codecov bot commented Oct 9, 2018

Codecov Report

Merging #1061 into master will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1061      +/-   ##
==========================================
+ Coverage   65.16%   65.24%   +0.08%     
==========================================
  Files          39       39              
  Lines        2733     2728       -5     
==========================================
- Hits         1781     1780       -1     
+ Misses        632      630       -2     
+ Partials      320      318       -2
Impacted Files Coverage Δ
core/mutator/entry/mutator.go 67.24% <ø> (+1.66%) ⬆️
core/integration/client_tests.go 85.26% <ø> (+0.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fd8ff9...0c31998. Read the comment docs.

gdbelvin added some commits Oct 9, 2018

@gdbelvin gdbelvin merged commit a70c371 into google:master Oct 9, 2018

5 checks passed

GolangCI No issues found!
Details
cla/google All necessary CLAs are signed
codecov/patch Coverage not affected when comparing 8e01baa...0c31998
Details
codecov/project 65.24% (+0.08%) compared to 8e01baa
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@gdbelvin gdbelvin deleted the gdbelvin:tink branch Oct 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment