Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API: Rename Epoch to Revision #1104

Merged
merged 5 commits into from Nov 8, 2018

Conversation

Projects
2 participants
@gdbelvin
Copy link
Collaborator

commented Nov 8, 2018

Revision is more consistent with trilian.Map.Revision.

Key Transparency places each Trillian Map Revision into a Log of Map Revisions. This MapRoot, LogInclusion pair is a KT Revision.

gdbelvin added some commits Nov 8, 2018

Rename Epoch -> Revision
git ls-files | xargs | sed -i 's/Epoch/Revision/g'
git ls-files | xargs | sed -i 's/epoch/revision/g'

@gdbelvin gdbelvin added this to In progress in API Update Hackathon via automation Nov 8, 2018

@gdbelvin gdbelvin requested a review from therealdrake Nov 8, 2018

Show resolved Hide resolved core/client/client.go Outdated
Show resolved Hide resolved core/client/client.go Outdated
Show resolved Hide resolved core/keyserver/epochs_test.go Outdated

gdbelvin added some commits Nov 8, 2018

@codecov

This comment has been minimized.

Copy link

commented Nov 8, 2018

Codecov Report

Merging #1104 into master will decrease coverage by 0.03%.
The diff coverage is 76.19%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1104      +/-   ##
==========================================
- Coverage    67.2%   67.16%   -0.04%     
==========================================
  Files          37       37              
  Lines        2680     2680              
==========================================
- Hits         1801     1800       -1     
- Misses        577      578       +1     
  Partials      302      302
Impacted Files Coverage Δ
impl/integration/env.go 72.97% <ø> (ø) ⬆️
core/integration/client_tests.go 84.78% <ø> (ø) ⬆️
core/monitor/verify.go 47.22% <ø> (ø) ⬆️
core/client/client.go 65% <100%> (ø) ⬆️
core/sequencer/server.go 65.19% <100%> (ø) ⬆️
core/monitorserver/server.go 30.43% <28.57%> (ø) ⬆️
core/client/get_and_verify.go 58.1% <50%> (ø) ⬆️
core/keyserver/validate.go 57.14% <57.14%> (ø) ⬆️
core/keyserver/keyserver.go 58.82% <62.5%> (ø) ⬆️
core/client/verify.go 54.16% <66.66%> (ø) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac84fc9...7bbf21d. Read the comment docs.

@gdbelvin gdbelvin merged commit 3d27c7e into google:master Nov 8, 2018

4 of 5 checks passed

GolangCI Processing timeout
cla/google All necessary CLAs are signed
codecov/patch 76.19% of diff hit (target 67.2%)
Details
codecov/project Absolute coverage decreased by -0.03% but relative coverage increased by +8.98% compared to ac84fc9
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

API Update Hackathon automation moved this from In progress to Done Nov 8, 2018

@gdbelvin gdbelvin deleted the gdbelvin:api/epoch_rev branch Nov 8, 2018

gdbelvin added a commit to gdbelvin/keytransparency that referenced this pull request Nov 8, 2018

Merge branch 'master' into prototool
* master:
  API: Rename Epoch to Revision (google#1104)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.