New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Loopback Connection in Sequencer #1137

Merged
merged 3 commits into from Nov 29, 2018

Conversation

Projects
None yet
3 participants
@gdbelvin
Collaborator

gdbelvin commented Nov 29, 2018

By making calls through the rpc layer, we produce rpc layer metrics through prometheus about DefineRevision, CreateRevision, and PublishRevision. These include periodicity, failure codes, latency, and a whole range of other metrics.

gdbelvin added some commits Nov 29, 2018

Listen on port before creating grpc server.
In order to pass a sequencer client to the sequencer server,
we need to grpc.Dial *before* the server is running.
This works because grpc.Dial is nonblocking by default.

@gdbelvin gdbelvin requested a review from jtoohill Nov 29, 2018

@gdbelvin gdbelvin added this to the Productionize milestone Nov 29, 2018

@gdbelvin gdbelvin changed the title from Use loopback connection in Sequencer to Use Loopback connection in Sequencer Nov 29, 2018

@gdbelvin gdbelvin changed the title from Use Loopback connection in Sequencer to Use Loopback Connection in Sequencer Nov 29, 2018

@codecov

This comment has been minimized.

codecov bot commented Nov 29, 2018

Codecov Report

Merging #1137 into master will decrease coverage by 0.02%.
The diff coverage is 84%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1137      +/-   ##
==========================================
- Coverage   66.18%   66.15%   -0.03%     
==========================================
  Files          38       38              
  Lines        2854     2828      -26     
==========================================
- Hits         1889     1871      -18     
+ Misses        645      641       -4     
+ Partials      320      316       -4
Impacted Files Coverage Δ
core/sequencer/sequencer.go 29.03% <ø> (-14.37%) ⬇️
core/sequencer/server.go 66.81% <100%> (-1.68%) ⬇️
impl/integration/env.go 75.47% <80%> (+2.49%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e55394f...814dd94. Read the comment docs.

@gdbelvin gdbelvin merged commit 3c6f62f into google:master Nov 29, 2018

5 checks passed

GolangCI No issues found!
Details
cla/google All necessary CLAs are signed
codecov/patch 84% of diff hit (target 66.18%)
Details
codecov/project Absolute coverage decreased by -0.02% but relative coverage increased by +17.81% compared to e55394f
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@gdbelvin gdbelvin deleted the gdbelvin:listen branch Nov 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment