New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linter backlog #1151

Merged
merged 4 commits into from Jan 8, 2019

Conversation

Projects
None yet
2 participants
@gdbelvin
Copy link
Collaborator

gdbelvin commented Jan 7, 2019

Turns on linting for the whole repo, not just fresh code.

  • Turn off noisy linters
  • Fix outstanding linter warnings

gdbelvin added some commits Jan 7, 2019

@gdbelvin gdbelvin requested a review from phad Jan 7, 2019

@codecov

This comment has been minimized.

Copy link

codecov bot commented Jan 7, 2019

Codecov Report

Merging #1151 into master will not change coverage.
The diff coverage is 10%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1151   +/-   ##
=======================================
  Coverage   64.62%   64.62%           
=======================================
  Files          41       41           
  Lines        3112     3112           
=======================================
  Hits         2011     2011           
  Misses        759      759           
  Partials      342      342
Impacted Files Coverage Δ
core/client/verify.go 53.42% <0%> (ø) ⬆️
core/client/get_and_verify.go 55.12% <0%> (ø) ⬆️
core/client/client.go 65.21% <0%> (ø) ⬆️
impl/sql/mutationstorage/mutations.go 68.42% <0%> (ø) ⬆️
impl/integration/env.go 75.47% <0%> (ø) ⬆️
impl/sql/directory/storage.go 70.47% <0%> (ø) ⬆️
core/integration/client_tests.go 86.12% <0%> (ø) ⬆️
core/keyserver/validate.go 54.38% <0%> (ø) ⬆️
core/crypto/vrf/p256/p256.go 82.22% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d1ee7a...4d29f01. Read the comment docs.

@phad

phad approved these changes Jan 8, 2019

@gdbelvin gdbelvin merged commit 468323b into google:master Jan 8, 2019

3 checks passed

GolangCI No issues found!
Details
cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@gdbelvin gdbelvin deleted the gdbelvin:golangci-lint branch Jan 8, 2019

gdbelvin added a commit to gdbelvin/keytransparency that referenced this pull request Jan 14, 2019

Merge branch 'master' into user
* master:
  Update API Documentation (google#1160)
  Lazy load key material (google#1161)
  Fix linter backlog (google#1151)
  Allow batch size to be configurable (google#1147)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment