New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docker-compose paths #1169

Merged
merged 8 commits into from Feb 4, 2019

Conversation

Projects
None yet
2 participants
@gdbelvin
Copy link
Collaborator

gdbelvin commented Jan 23, 2019

Fixes #1155

@codecov

This comment has been minimized.

Copy link

codecov bot commented Jan 23, 2019

Codecov Report

Merging #1169 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1169   +/-   ##
=======================================
  Coverage   65.33%   65.33%           
=======================================
  Files          43       43           
  Lines        3268     3268           
=======================================
  Hits         2135     2135           
  Misses        772      772           
  Partials      361      361

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6d8928...1a18324. Read the comment docs.

@gdbelvin gdbelvin requested a review from DazWilkin Jan 23, 2019

gdbelvin added some commits Jan 23, 2019

@gdbelvin

This comment has been minimized.

Copy link
Collaborator Author

gdbelvin commented Jan 28, 2019

@DazWilkin PTAL

@gdbelvin gdbelvin requested a review from Martin2112 Feb 4, 2019

@RJPercival
Copy link
Member

RJPercival left a comment

Have you considered adding a step to your Travis tests that runs docker-compose up and sends some requests to the KT server? That'd give you some confidence that the docker-compose config and the images all work.

@gdbelvin gdbelvin merged commit 4069549 into google:master Feb 4, 2019

5 checks passed

GolangCI No issues found!
Details
cla/google All necessary CLAs are signed
codecov/patch Coverage not affected when comparing 6d7133d...1a18324
Details
codecov/project 65.33% remains the same compared to 6d7133d
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@gdbelvin gdbelvin deleted the gdbelvin:compose branch Feb 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment