New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linter fixups #1197

Merged
merged 8 commits into from Feb 8, 2019

Conversation

Projects
None yet
2 participants
@gdbelvin
Copy link
Collaborator

gdbelvin commented Feb 8, 2019

  • Bump linter version to 1.13.2
  • Add checks for improper imports
  • Trim exception list

gdbelvin added some commits Feb 8, 2019

@gdbelvin gdbelvin force-pushed the gdbelvin:blacklist branch from 9daeb8d to e1eb7f6 Feb 8, 2019

@gdbelvin gdbelvin requested a review from Martin2112 Feb 8, 2019

gdbelvin added some commits Feb 8, 2019

Merge branch 'blacklist' of github.com:gdbelvin/keytransparency into …
…blacklist

* 'blacklist' of github.com:gdbelvin/keytransparency:
  Typo "hander" should be "handler" (#1196)
@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 8, 2019

Codecov Report

Merging #1197 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1197      +/-   ##
==========================================
- Coverage   65.04%   65.01%   -0.03%     
==========================================
  Files          46       46              
  Lines        3336     3336              
==========================================
- Hits         2170     2169       -1     
  Misses        810      810              
- Partials      356      357       +1
Impacted Files Coverage Δ
core/crypto/tinkio/pem.go 72% <ø> (ø) ⬆️
core/crypto/tinkio/protofile.go 0% <ø> (ø) ⬆️
core/sequencer/trillian_client.go 59.18% <0%> (-4.09%) ⬇️
core/sequencer/server.go 72.89% <0%> (-1.87%) ⬇️
impl/sql/directory/storage.go 69.17% <0%> (+1.5%) ⬆️
core/keyserver/revisions.go 65.82% <0%> (+1.89%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5487dfb...6c06afe. Read the comment docs.

@gdbelvin gdbelvin merged commit 25eae20 into google:master Feb 8, 2019

3 of 5 checks passed

codecov/project 65.01% (-0.03%) compared to 5487dfb
Details
GolangCI GolangCI is reviewing your Pull Request...
cla/google All necessary CLAs are signed
codecov/patch Coverage not affected when comparing 5487dfb...6c06afe
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@gdbelvin gdbelvin deleted the gdbelvin:blacklist branch Feb 8, 2019

gdbelvin added a commit to gdbelvin/keytransparency that referenced this pull request Feb 8, 2019

Merge branch 'master' into mysql
* master:
  Don't timeout users entering OAuth info (google#1195)
  Linter fixups (google#1197)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment