New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hang: run mastership tracker #1199

Merged
merged 2 commits into from Feb 8, 2019

Conversation

Projects
None yet
2 participants
@gdbelvin
Copy link
Collaborator

gdbelvin commented Feb 8, 2019

No description provided.

@gdbelvin gdbelvin added the bug label Feb 8, 2019

@gdbelvin gdbelvin requested a review from pavelkalinnikov Feb 8, 2019

@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 8, 2019

Codecov Report

Merging #1199 into master will increase coverage by 0.17%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1199      +/-   ##
==========================================
+ Coverage   64.86%   65.04%   +0.17%     
==========================================
  Files          46       46              
  Lines        3336     3336              
==========================================
+ Hits         2164     2170       +6     
+ Misses        813      810       -3     
+ Partials      359      356       -3
Impacted Files Coverage Δ
core/sequencer/server.go 74.76% <0%> (+1.86%) ⬆️
core/sequencer/trillian_client.go 63.26% <0%> (+4.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06aca66...06d32d7. Read the comment docs.

@gdbelvin gdbelvin merged commit edd2c90 into google:master Feb 8, 2019

4 of 5 checks passed

GolangCI Waiting in queue...
cla/google All necessary CLAs are signed
codecov/patch Coverage not affected when comparing 06aca66...06d32d7
Details
codecov/project 65.04% (+0.17%) compared to 06aca66
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@gdbelvin gdbelvin deleted the gdbelvin:hang branch Feb 8, 2019

gdbelvin added a commit to gdbelvin/keytransparency that referenced this pull request Feb 11, 2019

Merge branch 'master' into test
* master:
  Fix hang: run mastership tracker (google#1199)
  Support testing with docker (google#1198)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment