New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move mysql expose port to override compose file #1204

Merged
merged 1 commit into from Feb 11, 2019

Conversation

Projects
None yet
2 participants
@Zyqsempai
Copy link
Contributor

Zyqsempai commented Feb 8, 2019

Moved expose mysql port to override compose file
Related PR: #1201

@Zyqsempai Zyqsempai requested a review from gdbelvin as a code owner Feb 8, 2019

@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 8, 2019

Codecov Report

Merging #1204 into master will increase coverage by 0.29%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1204      +/-   ##
==========================================
+ Coverage   64.86%   65.16%   +0.29%     
==========================================
  Files          46       46              
  Lines        3336     3336              
==========================================
+ Hits         2164     2174      +10     
+ Misses        813      808       -5     
+ Partials      359      354       -5
Impacted Files Coverage Δ
core/sequencer/server.go 76.63% <0%> (+3.73%) ⬆️
impl/sql/mutationstorage/mutations.go 73.68% <0%> (+5.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update edd2c90...97afca9. Read the comment docs.

@gdbelvin gdbelvin merged commit d4a0678 into google:master Feb 11, 2019

5 checks passed

GolangCI No issues found!
Details
cla/google All necessary CLAs are signed
codecov/patch Coverage not affected when comparing edd2c90...97afca9
Details
codecov/project 65.16% (+0.29%) compared to edd2c90
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

gdbelvin added a commit to gdbelvin/keytransparency that referenced this pull request Feb 11, 2019

Merge branch 'test' of github.com:gdbelvin/keytransparency into test
* 'test' of github.com:gdbelvin/keytransparency:
  Move mysql expose port to override compose file (google#1204)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment