Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update travis.yml to xenial #1215

Merged
merged 3 commits into from Feb 22, 2019

Conversation

Projects
None yet
3 participants
@u5surf
Copy link
Contributor

u5surf commented Feb 18, 2019

fixes #1214
I fix .travis.yml to be able to use xenial images, docker and docker-compose which are default package in this images.

I don't know how fast build it using xenial images...
https://travis-ci.com/u5surf/keytransparency/jobs/178577965

@u5surf u5surf requested a review from gdbelvin as a code owner Feb 18, 2019

Show resolved Hide resolved .travis.yml
@gdbelvin
Copy link
Collaborator

gdbelvin left a comment

Thanks for this PR, and welcome as a first time contributor! 🥇

See if you can remove the other docker-compose install steps.

- pip3 install -U --user docker-compose

addons:	addons:
  apt:	  apt:
    packages:	    packages:
    - python3-pip

Please disregard the "fast build" comment -- you did exactly the right thing in this PR.

@google google deleted a comment from codecov bot Feb 18, 2019

u5surf added some commits Feb 20, 2019

@u5surf u5surf force-pushed the u5surf:issue-1214 branch from bc0a8bf to 061287e Feb 20, 2019

@google google deleted a comment from codecov bot Feb 22, 2019

@googlebot googlebot added the cla: yes label Feb 22, 2019

@gdbelvin
Copy link
Collaborator

gdbelvin left a comment

Looking good! Thanks :-)

@google google deleted a comment from codecov bot Feb 22, 2019

@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 22, 2019

Codecov Report

Merging #1215 into master will decrease coverage by 33.24%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1215       +/-   ##
===========================================
- Coverage   65.57%   32.32%   -33.25%     
===========================================
  Files          46       46               
  Lines        3375     3375               
===========================================
- Hits         2213     1091     -1122     
- Misses        803     2108     +1305     
+ Partials      359      176      -183
Impacted Files Coverage Δ
core/client/mutations.go 0% <0%> (-86.05%) ⬇️
core/integration/client_tests.go 0% <0%> (-85.55%) ⬇️
core/integration/monitor_tests.go 0% <0%> (-77.34%) ⬇️
impl/integration/env.go 0% <0%> (-75.48%) ⬇️
core/crypto/tinkio/pem.go 0% <0%> (-72%) ⬇️
core/client/batch_get_and_verify.go 0% <0%> (-70.59%) ⬇️
core/testutil/tink.go 0% <0%> (-66.67%) ⬇️
core/fake/monitorstorage.go 0% <0%> (-66.67%) ⬇️
core/sequencer/trillian_client.go 0% <0%> (-65.31%) ⬇️
core/client/batch_client.go 0% <0%> (-62.27%) ⬇️
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1586d76...a4839a0. Read the comment docs.

@gdbelvin gdbelvin merged commit 2631c37 into google:master Feb 22, 2019

4 of 5 checks passed

codecov/project 32.32% (-33.25%) compared to 1586d76
Details
GolangCI No issues found!
Details
cla/google All necessary CLAs are signed
codecov/patch Coverage not affected when comparing 1586d76...a4839a0
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

gdbelvin added a commit to gdbelvin/keytransparency that referenced this pull request Feb 22, 2019

Merge branch 'split' of github.com:gdbelvin/keytransparency into split
* 'split' of github.com:gdbelvin/keytransparency:
  update travis.yml to xenial (google#1215)
  (prexisting) remove unused vars

gdbelvin added a commit to gdbelvin/keytransparency that referenced this pull request Feb 22, 2019

Merge branch 'master' into reduce
* master:
  (prexisting) remove unused vars
  Fix mutation test
  Check for nil keyset
  Use IsValidEntry in Keyserver
  Separate out IsValidEntry helper
  Made logical split for mutation validation function
  update travis.yml to xenial (google#1215)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.