Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added keyset-file flag tp specify file path and name #1223

Merged
merged 2 commits into from Feb 25, 2019

Conversation

Projects
None yet
4 participants
@Zyqsempai
Copy link
Contributor

Zyqsempai commented Feb 25, 2019

Fixes #1213
Fixes #1206

Added keyset-file flag to specify keyset file path and name, for CREATE, LIST, POST and HAMMER commands.
Added small description of the new flag to README

@Zyqsempai Zyqsempai requested a review from gdbelvin as a code owner Feb 25, 2019

@googlebot googlebot added the cla: yes label Feb 25, 2019

@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 25, 2019

Codecov Report

Merging #1223 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1223   +/-   ##
=======================================
  Coverage   32.25%   32.25%           
=======================================
  Files          46       46           
  Lines        3379     3379           
=======================================
  Hits         1090     1090           
  Misses       2112     2112           
  Partials      177      177

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae85001...44bf5f8. Read the comment docs.

Show resolved Hide resolved README.md Outdated
@gdbelvin
Copy link
Collaborator

gdbelvin left a comment

LGTM. @DazWilkin - do these changes sufficiently address address #1206 ?

@googlebot

This comment has been minimized.

Copy link
Collaborator

googlebot commented Feb 25, 2019

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no and removed cla: yes labels Feb 25, 2019

@gdbelvin

This comment has been minimized.

Copy link
Collaborator

gdbelvin commented Feb 25, 2019

@Zyqsempai - Looks like we've upset the @googlebot again :-\
Rather than accepting my edit (which makes me a co-author), could you try rebasing or recreating the edit? Hopefully that should calm the bots :-)

@Zyqsempai

This comment has been minimized.

Copy link
Contributor Author

Zyqsempai commented Feb 25, 2019

@gdbelvin Ooh, that @googlebot is too sensitive;) Let me try to do something.

@Zyqsempai Zyqsempai force-pushed the Zyqsempai:add-keyset-dir-flag branch from d6ff29d to 44bf5f8 Feb 25, 2019

@googlebot

This comment has been minimized.

Copy link
Collaborator

googlebot commented Feb 25, 2019

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Feb 25, 2019

@gdbelvin gdbelvin requested a review from DazWilkin Feb 25, 2019

@gdbelvin

This comment has been minimized.

Copy link
Collaborator

gdbelvin commented Feb 25, 2019

@Zyqsempai Looks like that fixed it. Just waiting on input from @DazWilkin now

@DazWilkin

This comment has been minimized.

Copy link
Collaborator

DazWilkin commented Feb 25, 2019

@Zyqsempai Thank you.
@gdbelvin LGTM.

@gdbelvin gdbelvin merged commit cb47c70 into google:master Feb 25, 2019

5 checks passed

GolangCI No issues found!
Details
cla/google All necessary CLAs are signed
codecov/patch Coverage not affected when comparing ae85001...44bf5f8
Details
codecov/project 32.25% remains the same compared to ae85001
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.