Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove references to tinkpb.Keyset #1240

Merged
merged 6 commits into from Mar 11, 2019

Conversation

Projects
None yet
3 participants
@gdbelvin
Copy link
Collaborator

gdbelvin commented Mar 8, 2019

tinkpb.Keyset is a tink internal type. This PR removes all references to it.
Rather than referencing key material directly tink uses keyset.Handle to ensure that key material is treated correctly. By doing so, we benefit from the checks tink does on import and export.

Fixes #1211

@googlebot googlebot added the cla: yes label Mar 8, 2019

@gdbelvin gdbelvin requested a review from thaidn Mar 8, 2019

gdbelvin added some commits Mar 8, 2019

@gdbelvin gdbelvin force-pushed the gdbelvin:tink branch from fa5ba19 to 97e8c1f Mar 8, 2019

Merge branch 'master' into tink
* master:
  Read LogMessages in a MapFn (#1232)
@codecov

This comment has been minimized.

Copy link

codecov bot commented Mar 11, 2019

Codecov Report

Merging #1240 into master will decrease coverage by <.01%.
The diff coverage is 14.92%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1240      +/-   ##
==========================================
- Coverage   32.67%   32.66%   -0.01%     
==========================================
  Files          46       46              
  Lines        3452     3456       +4     
==========================================
+ Hits         1128     1129       +1     
- Misses       2138     2140       +2     
- Partials      186      187       +1
Impacted Files Coverage Δ
core/integration/monitor_tests.go 0% <0%> (ø) ⬆️
core/integration/client_tests.go 0% <0%> (ø) ⬆️
core/client/batch_client.go 0% <0%> (ø) ⬆️
core/client/client.go 29.55% <0%> (-0.63%) ⬇️
core/mutator/entry/mutator.go 38.82% <50%> (-0.21%) ⬇️
core/mutator/entry/mutation.go 73.13% <66.66%> (+0.4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89d0f47...fdba070. Read the comment docs.

@thaidn

thaidn approved these changes Mar 11, 2019

@gdbelvin gdbelvin merged commit 4b99d01 into google:master Mar 11, 2019

3 of 5 checks passed

codecov/patch 14.92% of diff hit (target 32.67%)
Details
codecov/project 32.66% (-0.01%) compared to ca01f13
Details
GolangCI No issues found!
Details
cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.