Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{List,Create,Change}InputLogs Admin APIs #1250

Merged
merged 13 commits into from Mar 29, 2019

Conversation

Projects
None yet
3 participants
@gdbelvin
Copy link
Collaborator

gdbelvin commented Mar 27, 2019

Support admin control of input log horizontal scaling.

Fixes #1063

gdbelvin added some commits Mar 27, 2019

@googlebot googlebot added the cla: yes label Mar 27, 2019

@gdbelvin gdbelvin requested a review from therealdrake Mar 27, 2019

@codecov

This comment has been minimized.

Copy link

codecov bot commented Mar 28, 2019

Codecov Report

Merging #1250 into master will increase coverage by 0.09%.
The diff coverage is 15.68%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1250      +/-   ##
=========================================
+ Coverage    32.2%   32.3%   +0.09%     
=========================================
  Files          45      45              
  Lines        3493    3517      +24     
=========================================
+ Hits         1125    1136      +11     
- Misses       2183    2198      +15     
+ Partials      185     183       -2
Impacted Files Coverage Δ
impl/sql/mutationstorage/queue.go 71.03% <100%> (+4.12%) ⬆️
core/adminserver/admin_server.go 22.95% <4.44%> (-2.33%) ⬇️
core/client/client.go 30.18% <0%> (+0.62%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6643f0...ec6ab31. Read the comment docs.

Show resolved Hide resolved core/adminserver/admin_server.go Outdated
Show resolved Hide resolved core/adminserver/admin_server.go Outdated
Show resolved Hide resolved core/adminserver/admin_server.go
Show resolved Hide resolved core/adminserver/admin_server.go Outdated
Show resolved Hide resolved impl/sql/mutationstorage/queue_test.go

gdbelvin added some commits Mar 29, 2019

Merge branch 'master' into writable
* master:
  Remove trailing whitespace in sequencer_api.proto (#1253)
  Add latency metrics to ApplyRevisions in Sequencer (#1252)

@gdbelvin gdbelvin requested a review from therealdrake Mar 29, 2019

@gdbelvin

This comment has been minimized.

Copy link
Collaborator Author

gdbelvin commented Mar 29, 2019

Updated. PTAL

Show resolved Hide resolved core/adminserver/admin_server.go Outdated
Show resolved Hide resolved core/adminserver/admin_server.go Outdated
nit

@gdbelvin gdbelvin merged commit 65451bd into master Mar 29, 2019

5 of 6 checks passed

codecov/patch 15.68% of diff hit (target 32.2%)
Details
GolangCI No issues found!
Details
cla/google All necessary CLAs are signed
codecov/project 32.3% (+0.09%) compared to b6643f0
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@gdbelvin gdbelvin deleted the writable branch Mar 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.