Skip to content
This repository has been archived by the owner. It is now read-only.

Set default code reviewer to @google/keytransparency #1257

Merged
merged 1 commit into from Apr 13, 2019
Merged

Set default code reviewer to @google/keytransparency #1257

merged 1 commit into from Apr 13, 2019

Conversation

@gdbelvin
Copy link
Contributor

@gdbelvin gdbelvin commented Apr 12, 2019

CODEOWNERS automatically assigns reviewers but it also requires an LGTM from
one of those reviewers, regardless of other LGTMs.

Remove single point of failure by expanding code ownership to include the whole
team.

@codecov
Copy link

@codecov codecov bot commented Apr 12, 2019

Codecov Report

Merging #1257 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1257   +/-   ##
=======================================
  Coverage   32.29%   32.29%           
=======================================
  Files          45       45           
  Lines        3518     3518           
=======================================
  Hits         1136     1136           
  Misses       2198     2198           
  Partials      184      184

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecb6637...e0afcd2. Read the comment docs.

@@ -5,4 +5,5 @@
# https://git-scm.com/docs/gitignore#_pattern_format

# Default
* @gdbelvin
* @google/keytransparency

That team only has 4 members, so maybe expand it a bit?

Copy link
Contributor Author

@gdbelvin gdbelvin Apr 12, 2019

Would love to expand. Who else would you suggest that has experience with this repo?

@@ -5,4 +5,5 @@
# https://git-scm.com/docs/gitignore#_pattern_format

# Default
* @gdbelvin
* @google/keytransparency
core/crypto @gdbelvin @thaidn @benbenoy

Are the 2 additional folk here aware that this is incoming?

Copy link
Contributor Author

@gdbelvin gdbelvin Apr 12, 2019

I'll hold off on this until I hear from them. Thanks for that suggestion.

@gdbelvin gdbelvin requested review from thaidn and and removed request for Apr 12, 2019
@gdbelvin gdbelvin merged commit 8e808ec into master Apr 13, 2019
6 checks passed
@gdbelvin gdbelvin deleted the empower branch Apr 13, 2019
@gdbelvin gdbelvin mentioned this pull request Dec 17, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants