Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default code reviewer to @google/keytransparency #1257

Merged
merged 1 commit into from Apr 13, 2019

Conversation

Projects
None yet
3 participants
@gdbelvin
Copy link
Collaborator

gdbelvin commented Apr 12, 2019

CODEOWNERS automatically assigns reviewers but it also requires an LGTM from
one of those reviewers, regardless of other LGTMs.

Remove single point of failure by expanding code ownership to include the whole
team.

@googlebot googlebot added the cla: yes label Apr 12, 2019

@gdbelvin gdbelvin requested a review from daviddrysdale Apr 12, 2019

@gdbelvin gdbelvin force-pushed the empower branch from c7d226f to e0afcd2 Apr 12, 2019

@codecov

This comment has been minimized.

Copy link

codecov bot commented Apr 12, 2019

Codecov Report

Merging #1257 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1257   +/-   ##
=======================================
  Coverage   32.29%   32.29%           
=======================================
  Files          45       45           
  Lines        3518     3518           
=======================================
  Hits         1136     1136           
  Misses       2198     2198           
  Partials      184      184

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecb6637...e0afcd2. Read the comment docs.

@@ -5,4 +5,5 @@
# https://git-scm.com/docs/gitignore#_pattern_format

# Default
* @gdbelvin
* @google/keytransparency

This comment has been minimized.

Copy link
@daviddrysdale

daviddrysdale Apr 12, 2019

That team only has 4 members, so maybe expand it a bit?

This comment has been minimized.

Copy link
@gdbelvin

gdbelvin Apr 12, 2019

Author Collaborator

Would love to expand. Who else would you suggest that has experience with this repo?

@@ -5,4 +5,5 @@
# https://git-scm.com/docs/gitignore#_pattern_format

# Default
* @gdbelvin
* @google/keytransparency
core/crypto @gdbelvin @thaidn @benbenoy

This comment has been minimized.

Copy link
@daviddrysdale

daviddrysdale Apr 12, 2019

Are the 2 additional folk here aware that this is incoming?

This comment has been minimized.

Copy link
@gdbelvin

gdbelvin Apr 12, 2019

Author Collaborator

I'll hold off on this until I hear from them. Thanks for that suggestion.

@gdbelvin gdbelvin requested review from thaidn and benbenoy and removed request for benbenoy Apr 12, 2019

@gdbelvin gdbelvin merged commit 8e808ec into master Apr 13, 2019

6 checks passed

GolangCI No issues found!
Details
cla/google All necessary CLAs are signed
codecov/patch Coverage not affected when comparing ecb6637...e0afcd2
Details
codecov/project 32.29% remains the same compared to ecb6637
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@gdbelvin gdbelvin deleted the empower branch Apr 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.